From: Georgy Kirichenko <georgy@tarantool.org> To: tarantool-patches@freelists.org Cc: Konstantin Belyavskiy <k.belyavskiy@tarantool.org> Subject: [tarantool-patches] Re: [PATCH] lua: fix for option changed by tarantoolctl Date: Mon, 23 Jul 2018 16:23:08 +0300 [thread overview] Message-ID: <3578005.8AOcFEYhFo@localhost> (raw) In-Reply-To: <20180720165359.8718-1-k.belyavskiy@tarantool.org> [-- Attachment #1: Type: text/plain, Size: 495 bytes --] I am sorry but it is completelly wrong > + if cfg.pid_file ~= default_cfg.pid_file then > + log.warn("then using with tarantoolctl option 'pid_file' is > ignored") + cfg.pid_file = default_cfg.pid_file > + end How should this fix the issue? > - box.error(box.error.RELOAD_CFG, key); > + -- then started with tarantoolctl this option is set to > + -- default value, see #3214. > + if key == "pid_file" then What is it "pid_file"? [-- Attachment #2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2018-07-23 13:23 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-07-20 16:53 [tarantool-patches] " Konstantin Belyavskiy 2018-07-23 13:23 ` Georgy Kirichenko [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3578005.8AOcFEYhFo@localhost \ --to=georgy@tarantool.org \ --cc=k.belyavskiy@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='[tarantool-patches] Re: [PATCH] lua: fix for option changed by tarantoolctl' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox