Tarantool development patches archive
 help / color / mirror / Atom feed
From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Imeev Mergen <imeevma@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v3 6/6] sql: set column types for EXPLAIN and PRAGMA
Date: Wed, 16 Jan 2019 18:35:29 +0300	[thread overview]
Message-ID: <35575ED0-F934-4EAC-A955-51CD43347A9B@tarantool.org> (raw)
In-Reply-To: <c087a86c4da62b9b73361b8e483606facd2f92b2.1545844480.git.imeevma@gmail.com>


> @@ -471,17 +464,15 @@ sqlite3Pragma(Parse * pParse, Token * pId,	/* First part of [schema.]id field */
> 		goto pragma_out;
> 	}
> 	/* Register the result column names for pragmas that return results */
> -	if ((pPragma->mPragFlg & PragFlg_NoColumns) == 0
> -	    && ((pPragma->mPragFlg & PragFlg_NoColumns1) == 0 || zRight == 0)
> -	    ) {
> -		setPragmaResultColumnNames(v, pPragma);
> -	}
> +	if ((pPragma->mPragFlg & PragFlg_NoColumns) == 0 &&
> +	    ((pPragma->mPragFlg & PragFlg_NoColumns1) == 0 || zRight == 0))
> +		vdbe_set_pragma_result_columns(v, pPragma);

zRight != NULL

The rest seems to be OK.

      reply	other threads:[~2019-01-16 15:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-26 18:17 [tarantool-patches] [PATCH v3 0/6] " imeevma
2018-12-26 18:17 ` [tarantool-patches] [PATCH v3 1/6] sql: remove unused macros from pragma.c and pragma.h imeevma
2019-01-16 15:34   ` [tarantool-patches] " n.pettik
2018-12-26 18:18 ` [tarantool-patches] [PATCH v3 2/6] sql: fix "PRAGMA parser_trace" result imeevma
2019-01-16 15:35   ` [tarantool-patches] " n.pettik
2018-12-26 18:18 ` [tarantool-patches] [PATCH v3 3/6] sql: Show currently set sql_default_engine imeevma
2018-12-26 18:18 ` [tarantool-patches] [PATCH v3 4/6] sql: fix "PRAGMA case_sensitive_like" result imeevma
2019-01-16 15:35   ` [tarantool-patches] " n.pettik
2018-12-26 18:18 ` [tarantool-patches] [PATCH v3 5/6] sql: 'PRAGMA' result in the appropriate format imeevma
2019-01-16 15:35   ` [tarantool-patches] " n.pettik
2018-12-26 18:18 ` [tarantool-patches] [PATCH v3 6/6] sql: set column types for EXPLAIN and PRAGMA imeevma
2019-01-16 15:35   ` n.pettik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35575ED0-F934-4EAC-A955-51CD43347A9B@tarantool.org \
    --to=korablev@tarantool.org \
    --cc=imeevma@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v3 6/6] sql: set column types for EXPLAIN and PRAGMA' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox