From: Serge Petrenko <sergepetrenko@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 2/5] [tosquash] applier: remove unnecessary fiber name check
Date: Sun, 5 Jul 2020 11:40:36 +0300 [thread overview]
Message-ID: <3553d0d7-a15b-193d-869e-b84b74b3754f@tarantool.org> (raw)
In-Reply-To: <2108e63a8386c036f43e6cf01666587541e18e61.1593733161.git.v.shpilevoy@tarantool.org>
03.07.2020 02:40, Vladislav Shpilevoy пишет:
> This was an artifact from a first version of the patch.
> Of course it is not valid, because final commit of this
> transaction can be done by any fiber.
Hi! Thanks for the patch! LGTM.
> ---
> src/box/applier.cc | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/src/box/applier.cc b/src/box/applier.cc
> index 7e70211b7..9a9ec1dac 100644
> --- a/src/box/applier.cc
> +++ b/src/box/applier.cc
> @@ -806,7 +806,6 @@ applier_txn_commit_cb(struct trigger *trigger, void *event)
> (void) trigger;
> struct txn *txn = (struct txn *)event;
> assert(txn->fiber != NULL);
> - assert(strncmp(txn->fiber->name, "applierw", 8) == 0);
> /*
> * Let the txn module free the transaction object. It is
> * not needed for anything else.
--
Serge Petrenko
next prev parent reply other threads:[~2020-07-05 8:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 23:40 [Tarantool-patches] [PATCH 0/5] Qsync: local rows fixes Vladislav Shpilevoy
2020-07-02 23:40 ` [Tarantool-patches] [PATCH 1/5] [tosquash] replication: fix multiple rollbacks Vladislav Shpilevoy
2020-07-05 9:34 ` Serge Petrenko
2020-07-05 15:13 ` Vladislav Shpilevoy
2020-07-02 23:40 ` [Tarantool-patches] [PATCH 2/5] [tosquash] applier: remove unnecessary fiber name check Vladislav Shpilevoy
2020-07-05 8:40 ` Serge Petrenko [this message]
2020-07-02 23:40 ` [Tarantool-patches] [PATCH 3/5] [tosquash] txn_limbo: fix release build Vladislav Shpilevoy
2020-07-05 8:41 ` Serge Petrenko
2020-07-02 23:40 ` [Tarantool-patches] [PATCH 4/5] [tosquash] replication: rework how local transactions wait sync Vladislav Shpilevoy
2020-07-05 9:04 ` Serge Petrenko
2020-07-05 15:13 ` Vladislav Shpilevoy
2020-07-02 23:40 ` [Tarantool-patches] [PATCH 5/5] [tosquash] replication: add test on local row in the end of sync txn Vladislav Shpilevoy
2020-07-05 9:11 ` Serge Petrenko
2020-07-05 15:13 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3553d0d7-a15b-193d-869e-b84b74b3754f@tarantool.org \
--to=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2/5] [tosquash] applier: remove unnecessary fiber name check' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox