From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Konstantin Osipov <kostja.osipov@gmail.com>,
tarantool-patches@dev.tarantool.org, olegrok@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH vshard 1/1] router: bucket_id_strcrc32 and bucket_id_mpcrc32
Date: Thu, 27 Feb 2020 01:25:18 +0100 [thread overview]
Message-ID: <352307e9-cc71-2f26-8beb-148a3e0cd3de@tarantool.org> (raw)
In-Reply-To: <20200226082029.GA5040@atlas>
On 26/02/2020 09:20, Konstantin Osipov wrote:
> * Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [20/02/26 09:31]:
>> Closes #207
>
> While you're at it, is this hardware crc32?
Yes, this is hardware, when possible. And it is in C. See crc32.c
files (there are two of them).
>
> Did you consider implementing it in C as a server built-in to
> avoid using messagepack as an interim representation?
MessagePack is chosen not because of speed (although it is the
same as with tostring(), according to my benches, and even a little
faster on numbers), but because of bad representation of Lua cdata
numbers in strings.
next prev parent reply other threads:[~2020-02-27 0:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 23:52 Vladislav Shpilevoy
2020-02-26 7:15 ` Oleg Babin
2020-02-27 0:22 ` Vladislav Shpilevoy
2020-02-27 10:12 ` Oleg Babin
2020-02-29 17:09 ` Vladislav Shpilevoy
2020-03-02 8:10 ` Oleg Babin
2020-03-02 21:06 ` Vladislav Shpilevoy
2020-02-26 8:20 ` Konstantin Osipov
2020-02-27 0:25 ` Vladislav Shpilevoy [this message]
2020-02-27 6:53 ` Konstantin Osipov
2020-02-29 17:10 ` Vladislav Shpilevoy
2020-03-01 16:52 ` Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=352307e9-cc71-2f26-8beb-148a3e0cd3de@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kostja.osipov@gmail.com \
--cc=olegrok@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH vshard 1/1] router: bucket_id_strcrc32 and bucket_id_mpcrc32' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox