From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>,
Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] test: fix Clang warning in LuaJIT-tests
Date: Wed, 11 Dec 2024 20:20:03 +0300 [thread overview]
Message-ID: <336922f4-4da5-494c-88da-6ab28ccbc855@tarantool.org> (raw)
In-Reply-To: <20241119105809.18234-1-skaplun@tarantool.org>
[-- Attachment #1: Type: text/plain, Size: 1353 bytes --]
Hi, Sergey
thanks for the patch! LGTM
On 19.11.2024 13:58, Sergey Kaplun wrote:
> This patch fixes the warning in <libctest.c> produced by Clang:
> | warning: plain '_Complex' requires a type specifier; assuming
> | '_Complex double'
> by adding the `double` type specifier where it is needed.
> ---
>
> Branch:https://github.com/tarantool/luajit/tree/skaplun/fix-test-complex-double
>
> test/LuaJIT-tests/src/libctest.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/test/LuaJIT-tests/src/libctest.c b/test/LuaJIT-tests/src/libctest.c
> index aa95b57b..955383d7 100644
> --- a/test/LuaJIT-tests/src/libctest.c
> +++ b/test/LuaJIT-tests/src/libctest.c
> @@ -73,9 +73,9 @@ LUA_API double call_ividi(int a, ...)
> }
>
> #ifdef complex
> -LUA_API complex call_dd_cd(double a, double b) { return a+b*2i; }
> -LUA_API complex call_cd(complex a) { return a+1-2i; }
> -LUA_API complex call_cdcd(complex a, complex b) { return a+b; }
> +LUA_API complex double call_dd_cd(double a, double b) { return a+b*2i; }
> +LUA_API complex double call_cd(complex double a) { return a+1-2i; }
> +LUA_API complex double call_cdcd(complex double a, complex double b) { return a+b; }
>
> LUA_API complex float call_ff_cf(float a, float b) { return a+b*2i; }
> LUA_API complex float call_cf(complex float a) { return a+1-2i; }
[-- Attachment #2: Type: text/html, Size: 1884 bytes --]
next prev parent reply other threads:[~2024-12-11 17:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 10:58 Sergey Kaplun via Tarantool-patches
2024-12-11 17:20 ` Sergey Bronnikov via Tarantool-patches [this message]
2024-12-12 10:33 ` Maxim Kokryashkin via Tarantool-patches
2024-12-17 12:33 ` Sergey Kaplun via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=336922f4-4da5-494c-88da-6ab28ccbc855@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=m.kokryashkin@tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] test: fix Clang warning in LuaJIT-tests' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox