Tarantool development patches archive
 help / color / mirror / Atom feed
From: Serge Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>,
	Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v32 0/2] qsync: implement packet filtering (part 1)
Date: Fri, 4 Mar 2022 10:11:47 +0300	[thread overview]
Message-ID: <32fa5b99-0206-0d68-9ebe-eb139868e02f@tarantool.org> (raw)
In-Reply-To: <20220304060105.1186867-1-gorcunov@gmail.com>



04.03.2022 09:01, Cyrill Gorcunov пишет:
> Guys, take a look please, once time permit. Comments are welcome!
>
> v30:
>   - addess commenst (redundant code modifications due to more general
>     locking scheme)
>   - leave `latched` status for transactions which are started to
>     process (ie entered limbo processing) but not yet complete due
>     to WAL stalls, since I need to test exactly such state
>   - extend the test
>
> v31 (by SergeP):
>   - drop latch_is_locked member
>   - use `busy` flag in info output
>   - update test case (kudos to SergeP for help)
>
> v32 (by SergeP):
>   - update test
>   - improve changelogs (adding tags)
>   - merge test with second patch
>
> branch gorcunov/gh-6036-rollback-confirm-32
> issue https://github.com/tarantool/tarantool/issues/6036
> previous series https://lists.tarantool.org/tarantool-patches/20220302202711.1003906-1-gorcunov@gmail.com/
>
> Cyrill Gorcunov (2):
>    latch: add latch_is_locked helper
>    qsync: order access to the limbo terms
>
>   .../unreleased/gh-6036-applier-fix-race.md    |   5 +
>   src/box/applier.cc                            |   6 +-
>   src/box/box.cc                                |   8 +-
>   src/box/lua/info.c                            |   4 +-
>   src/box/txn_limbo.c                           |  13 +-
>   src/box/txn_limbo.h                           |  44 +++-
>   src/lib/core/latch.h                          |  11 +
>   .../gh_6036_qsync_order_test.lua              | 194 ++++++++++++++++++
>   test/replication-luatest/suite.ini            |   1 +
>   9 files changed, 276 insertions(+), 10 deletions(-)
>   create mode 100644 changelogs/unreleased/gh-6036-applier-fix-race.md
>   create mode 100644 test/replication-luatest/gh_6036_qsync_order_test.lua
>
>
> base-commit: 884b3ff3ffa5f6a9d4c3982611da83dc935d0b17
Thanks for the patchset! LGTM.

-- 
Serge Petrenko


  parent reply	other threads:[~2022-03-04  7:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-04  6:01 Cyrill Gorcunov via Tarantool-patches
2022-03-04  6:01 ` [Tarantool-patches] [PATCH v32 1/2] latch: add latch_is_locked helper Cyrill Gorcunov via Tarantool-patches
2022-03-04  6:01 ` [Tarantool-patches] [PATCH v32 2/2] qsync: order access to the limbo terms Cyrill Gorcunov via Tarantool-patches
2022-03-04  7:11 ` Serge Petrenko via Tarantool-patches [this message]
2022-03-04  9:34   ` [Tarantool-patches] [PATCH v32 0/2] qsync: implement packet filtering (part 1) Cyrill Gorcunov via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32fa5b99-0206-0d68-9ebe-eb139868e02f@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=gorcunov@gmail.com \
    --cc=sergepetrenko@tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v32 0/2] qsync: implement packet filtering (part 1)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox