From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 4BA376E454; Fri, 4 Mar 2022 10:11:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4BA376E454 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1646377910; bh=yFZM4FXIUNlS77r58kdruZOcUtxftWSPavxJa6wbSag=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=j8KC//UGAP0myd5xxmrOtUAUjSYFd9MoEwyqWcg58WKg4QNR0yKIduKdky5OVfG0V BbHCLxCg6Sfzb9dX7yUxd1uURhzbobdlci3H669VmYGNVfSseN5lz2G0/wAPr54aGL iPeUG/qJURE/BMljp5nNPyFNzReOUNsfmaijZXuU= Received: from smtp31.i.mail.ru (smtp31.i.mail.ru [94.100.177.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1F1CF6E454 for ; Fri, 4 Mar 2022 10:11:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1F1CF6E454 Received: by smtp31.i.mail.ru with esmtpa (envelope-from ) id 1nQ26O-0004I0-3D; Fri, 04 Mar 2022 10:11:48 +0300 Message-ID: <32fa5b99-0206-0d68-9ebe-eb139868e02f@tarantool.org> Date: Fri, 4 Mar 2022 10:11:47 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Content-Language: ru To: Cyrill Gorcunov , Vladislav Shpilevoy References: <20220304060105.1186867-1-gorcunov@gmail.com> In-Reply-To: <20220304060105.1186867-1-gorcunov@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD980F86DB526B8BEEF93D0AB86E11251C25BF486F69ABE748D182A05F53808504050BB1D1208679B494341700D40AECEEA2223DD8015A75B9F0639E610CFF75AAA X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70D278D70F8433719EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F9CBC1404CDFA5A08638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D84486927AF2238E5132E0C8AE0AACCD5C117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18CB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE7B96B19DC4093321CE99E4F20BAF2718D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE389DDFE3E282F3DD12D242C3BD2E3F4C6C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637A7EFCB0EB5ACB161EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 0D63561A33F958A583B03F724FF798078B9958C081F57B7FD95485D87C62246ED59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA754DBC578B17CB11D78E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34BD150993ED26DDF4EE313BC72A771A91549A0E4FA7976A40D4E785C5626DDC54756621A036142B3F1D7E09C32AA3244CB93AABBEF53A530CD3D7B267F8C98262725D5B54B2FE4575927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojiOLg73bewXS/K9QG0ZwtRw== X-Mailru-Sender: 11C2EC085EDE56FA38FD4C59F7EFE407D9BFEEB3BFA883CC5029A3135A03476F532CED4E0E5C03BC6BB2E709EA627F343C7DDD459B58856F0E45BC603594F5A135B915D4279FF0574198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v32 0/2] qsync: implement packet filtering (part 1) X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Cc: tml Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 04.03.2022 09:01, Cyrill Gorcunov пишет: > Guys, take a look please, once time permit. Comments are welcome! > > v30: > - addess commenst (redundant code modifications due to more general > locking scheme) > - leave `latched` status for transactions which are started to > process (ie entered limbo processing) but not yet complete due > to WAL stalls, since I need to test exactly such state > - extend the test > > v31 (by SergeP): > - drop latch_is_locked member > - use `busy` flag in info output > - update test case (kudos to SergeP for help) > > v32 (by SergeP): > - update test > - improve changelogs (adding tags) > - merge test with second patch > > branch gorcunov/gh-6036-rollback-confirm-32 > issue https://github.com/tarantool/tarantool/issues/6036 > previous series https://lists.tarantool.org/tarantool-patches/20220302202711.1003906-1-gorcunov@gmail.com/ > > Cyrill Gorcunov (2): > latch: add latch_is_locked helper > qsync: order access to the limbo terms > > .../unreleased/gh-6036-applier-fix-race.md | 5 + > src/box/applier.cc | 6 +- > src/box/box.cc | 8 +- > src/box/lua/info.c | 4 +- > src/box/txn_limbo.c | 13 +- > src/box/txn_limbo.h | 44 +++- > src/lib/core/latch.h | 11 + > .../gh_6036_qsync_order_test.lua | 194 ++++++++++++++++++ > test/replication-luatest/suite.ini | 1 + > 9 files changed, 276 insertions(+), 10 deletions(-) > create mode 100644 changelogs/unreleased/gh-6036-applier-fix-race.md > create mode 100644 test/replication-luatest/gh_6036_qsync_order_test.lua > > > base-commit: 884b3ff3ffa5f6a9d4c3982611da83dc935d0b17 Thanks for the patchset! LGTM. -- Serge Petrenko