Re: [Tarantool-patches] [PATCH luajit] Respect jit.off() on pending trace exit.

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

On 1/23/24 16:14, Sergey Kaplun wrote:
> Hi, Sergey!
> Thanks for the review!
<snipped>
> +
> +assert(traceinfo(1), 'root trace not compiled')
>> It is not clear what "1" means (here and below). As I got it right, it
>> is a trace number.
>>
>> I would left a comment about magic number or replace constant with
>> variable with self-explained name.
> Added the following comment. Branch is force-pushed.

Thanks!

LGTM as I said before


>
> ===================================================================
> diff --git a/test/tarantool-tests/lj-1134-hotside-jit-off.test.lua b/test/tarantool-tests/lj-1134-hotside-jit-off.test.lua
> index cdee3eb2..080b1e87 100644
> --- a/test/tarantool-tests/lj-1134-hotside-jit-off.test.lua
> +++ b/test/tarantool-tests/lj-1134-hotside-jit-off.test.lua
> @@ -9,6 +9,7 @@ local test = tap.test('lj-1134-hotside-jit-off'):skipcond({
>     ['Disabled on *BSD due to #4819'] = jit.os == 'BSD',
>   })
>   
> +-- `traceinfo()` takes the trace number as an argument.
>   local traceinfo = require('jit.util').traceinfo
>   
>   test:plan(1)
> ===================================================================
>
<snipped>