From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id EBC4B9ABE89; Thu, 25 Jan 2024 10:49:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EBC4B9ABE89 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1706168979; bh=ojhLeGUA9E/GUKGuHFhtg/elvlbFYFQagENL+O+Qviw=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=NFXw9lAwrTgzyhUXQzEgRdi0zpe1pwOu22JuM1NccLyDYjvqi741bEQ+NIQOI1Z/2 uMYcb9ewY686fiuzVoz1h7nq1I0YpRF5KQweY11ZVElYp2c4oT2jp/VRGZfkMAojF9 pM2deG53Ew6wSJQAhtSuyi/ugaTVXRDZ4o0d5vCU= Received: from smtp16.i.mail.ru (smtp16.i.mail.ru [95.163.41.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5661C9ABE92 for ; Thu, 25 Jan 2024 10:49:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5661C9ABE92 Received: by smtp16.i.mail.ru with esmtpa (envelope-from ) id 1rSuUS-005GBJ-24; Thu, 25 Jan 2024 10:49:36 +0300 Message-ID: <3272068e-059a-4e8f-881a-f811df7ea057@tarantool.org> Date: Thu, 25 Jan 2024 10:49:36 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun References: <20240122093234.14407-1-skaplun@tarantool.org> <793b7d4e-7d5f-4f77-bb82-c4496a94702a@tarantool.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD96A58C36AA2E996498065D321F2FD018AEFC0421552190AD0182A05F5380850403E42F34A22809F33DCEB15DC597A67F4FB773BA98D650A350F1E2C5115F6DC98 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7ECD3FEFFF0C7120DC2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE705C173BDDADFC82AEA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B73AB1701401CD871401312D54D81725FC83459E25971D2ABCC7F00164DA146DAFE8445B8C89999728AA50765F7900637251A55D428191A2F389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8706E30CA52318619F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C4E7D9683544204AFAD7EC71F1DB884274AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3F78FB55F308B71C4BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CFE478A468B35FE7671DD303D21008E298D5E8D9A59859A8B6D082881546D9349175ECD9A6C639B01B78DA827A17800CE73D56AD9F5B48EAD3731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A53B1F832DA86656D28D473ABFA5034CE451AA1021F38D39E3F87CCE6106E1FC07E67D4AC08A07B9B05B63D382EEF4D896CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF5A5F5E6AC470ED7018489FF488B7516C3660EFD2AF5FB9498A7CF468FE8D50056F890FCD3CEE011B4BEAD515961AA0A7582467275B51870D21209BC7CFCBFAA3E48CAC7CA610320002C26D483E81D6BE0DBAE6F56676BC7117BB6831D7356A2DEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojjPo90oGNxwIAgE3PuojPpA== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A7692138F5C8D5F37D17DCEB15DC597A67F4816609AA8FC7A761EBA65886582A37BD66FEC6BF5C9C28D98A98C1125256619760D574B6FC815AB872D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Respect jit.off() on pending trace exit. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 1/23/24 16:14, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review! > + > +assert(traceinfo(1), 'root trace not compiled') >> It is not clear what "1" means (here and below). As I got it right, it >> is a trace number. >> >> I would left a comment about magic number or replace constant with >> variable with self-explained name. > Added the following comment. Branch is force-pushed. Thanks! LGTM as I said before > > =================================================================== > diff --git a/test/tarantool-tests/lj-1134-hotside-jit-off.test.lua b/test/tarantool-tests/lj-1134-hotside-jit-off.test.lua > index cdee3eb2..080b1e87 100644 > --- a/test/tarantool-tests/lj-1134-hotside-jit-off.test.lua > +++ b/test/tarantool-tests/lj-1134-hotside-jit-off.test.lua > @@ -9,6 +9,7 @@ local test = tap.test('lj-1134-hotside-jit-off'):skipcond({ > ['Disabled on *BSD due to #4819'] = jit.os == 'BSD', > }) > > +-- `traceinfo()` takes the trace number as an argument. > local traceinfo = require('jit.util').traceinfo > > test:plan(1) > =================================================================== >