From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org,
Konstantin Osipov <kostja@tarantool.org>
Cc: vdavydov.dev@gmail.com
Subject: Re: [tarantool-patches] Re: [PATCH 2/4] iproto: fire on_disconnect right after disconnect
Date: Tue, 11 Dec 2018 15:55:06 +0300 [thread overview]
Message-ID: <322dad9a-cb57-f896-19c3-2350b4de3b6e@tarantool.org> (raw)
In-Reply-To: <20181207173730.GD840@chai>
On 07/12/2018 20:37, Konstantin Osipov wrote:
> * Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [18/12/07 18:48]:
>> Before the patch on_disconnect triggers were called
>> only after last outstanding request had finished. It
>> was enough for most goals. But after box.session.push
>> was implemented, it appeared that it is impossible to
>> return an error from push() if a connection is closed.
>>
>> Tx session just does not know that a connection is
>> already closed. The patch splits destroy and
>> disconnect phases of an iproto connection lifecycle.
>> Disconnect calls on_disconnect triggers and resets
>> iproto socket fd. Destroy frees resources.
>
> OK to push.
>
>> Needed for #3859
>
>
Pushed to 2.1 and 1.10.
next prev parent reply other threads:[~2018-12-11 12:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 15:46 [PATCH 0/4] Outdate disconnected session Vladislav Shpilevoy
2018-12-07 15:46 ` [PATCH 1/4] iproto: rename disconnect cmsg to destroy Vladislav Shpilevoy
2018-12-07 17:36 ` [tarantool-patches] " Konstantin Osipov
2018-12-11 12:54 ` [tarantool-patches] " Vladislav Shpilevoy
2018-12-07 15:46 ` [PATCH 2/4] iproto: fire on_disconnect right after disconnect Vladislav Shpilevoy
2018-12-07 17:37 ` [tarantool-patches] " Konstantin Osipov
2018-12-11 12:55 ` Vladislav Shpilevoy [this message]
2018-12-07 15:46 ` [PATCH 3/4] session: introduce 'dead' type Vladislav Shpilevoy
2018-12-07 17:38 ` [tarantool-patches] " Konstantin Osipov
2018-12-07 20:40 ` [tarantool-patches] " Vladislav Shpilevoy
2018-12-07 22:21 ` Konstantin Osipov
2018-12-07 22:42 ` Vladislav Shpilevoy
2018-12-07 15:46 ` [PATCH 4/4] session: kill a session of a closed connection Vladislav Shpilevoy
2018-12-07 17:35 ` [tarantool-patches] [PATCH 0/4] Outdate disconnected session Konstantin Osipov
2018-12-11 16:12 ` [tarantool-patches] " Vladislav Shpilevoy
2018-12-07 17:41 ` [tarantool-patches] " Konstantin Osipov
2018-12-11 16:13 ` [tarantool-patches] " Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=322dad9a-cb57-f896-19c3-2350b4de3b6e@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [tarantool-patches] Re: [PATCH 2/4] iproto: fire on_disconnect right after disconnect' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox