From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Kaplun <skaplun@tarantool.org> Cc: Sergey Bronnikov <estetus@gmail.com>, tarantool-patches@dev.tarantool.org, max.kokryashkin@gmail.com Subject: Re: [Tarantool-patches] [PATCH luajit] Fix predict_next() in parser (again). Date: Tue, 29 Aug 2023 18:11:04 +0300 [thread overview] Message-ID: <31d78cfd-f465-05ac-e94b-7c48b36439ed@tarantool.org> (raw) In-Reply-To: <ZO4ELMUPPFFZj9Nl@root> Hi, On 8/29/23 17:43, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the updates! > LGTM, after fixing several minor comments below. > > On 29.08.23, Sergey Bronnikov wrote: <snipped> > Part of tarantool/tarantool#8825 > --- > > PR:https://github.com/tarantool/tarantool/pull/9054 > Branch:https://github.com/tarantool/luajit/tree/ligurio/lj-1054-incorrect-pc-value-predict_next > Related issue: > *https://github.com/LuaJIT/LuaJIT/issues/1054 > > src/lj_parse.c | 4 +++- > ...incorrect-pc-value-in-predict_next.test.lua | 18 ++++++++++++++++++ > I suggest to use predict-next instead in filename and testname to be > consistent with other tests. Fixed: --- a/test/tarantool-tests/lj-1054-fix-incorrect-pc-value-in-predict_next.test.lua +++ b/test/tarantool-tests/lj-1054-fix-incorrect-pc-value-in-predict_next.test.lua @@ -1,12 +1,12 @@ local tap = require('tap') -local test = tap.test('lj-1054-incorrect-pc-value-in-predict_next') +local test = tap.test('lj-1054-fix-incorrect-pc-value-in-predict_next') test:plan(3) <snipped> >>>> +-- See alsohttps://github.com/LuaJIT/LuaJIT/issues/528 > Nit: Missed dot at the end of the sentence. > Typo: s/528/1054./ > > <snipped> > -- The test demonstrates a problem with out-of-boundary -- access to a stack. The problem can be easily observed -- on execution the sample by LuaJIT by ASAN, sanitizer -- reports a heap-based buffer overflow. --- See also https://github.com/LuaJIT/LuaJIT/issues/528 +-- See also https://github.com/LuaJIT/LuaJIT/issues/1054. local res_f = loadstring([[ a, b, c = 1, 2, 3
next prev parent reply other threads:[~2023-08-29 15:11 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-08-29 10:42 Sergey Bronnikov via Tarantool-patches 2023-08-29 13:38 ` Sergey Kaplun via Tarantool-patches 2023-08-29 14:38 ` Sergey Bronnikov via Tarantool-patches 2023-08-29 14:43 ` Sergey Kaplun via Tarantool-patches 2023-08-29 15:11 ` Sergey Bronnikov via Tarantool-patches [this message] 2023-08-30 10:53 ` Maxim Kokryashkin via Tarantool-patches 2023-08-31 11:48 ` Sergey Bronnikov via Tarantool-patches 2023-09-27 12:33 ` Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=31d78cfd-f465-05ac-e94b-7c48b36439ed@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=estetus@gmail.com \ --cc=max.kokryashkin@gmail.com \ --cc=sergeyb@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit] Fix predict_next() in parser (again).' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox