From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> To: Georgy Kirichenko <georgy@tarantool.org>, tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH] region: take allocated region size instead of used one Date: Tue, 4 Feb 2020 22:25:54 +0100 [thread overview] Message-ID: <2dccd4ca-9f29-c71d-f49c-da6722a5e743@tarantool.org> (raw) In-Reply-To: <20200127193320.33773-1-georgy@tarantool.org> Hi! Thanks for the patch! On 27/01/2020 20:33, Georgy Kirichenko wrote: > As region has cached but not used slabs take the full region size > in account while fiber gc. Please, describe the problem you are trying to solve. The text above just narrates the code. If this is related to the perf degradation, then there is another hint for you: region_reset() looks like this: static inline void region_reset(struct region *region) { struct rslab *slab; rlist_foreach_entry(slab, ®ion->slabs.slabs, slab.next_in_list) { region->slabs.stats.used -= slab->used; slab->used = 0; } } But in fact you can stop when you see first 'used == 0', because all the next slabs anyway have used 0 too (from what I see in the code). So as not to add an 'if' here, we could in struct region keep a pointer at the last slab having used != 0. And iterate till it. > Fixes #4736 > > diff --git a/src/lib/core/fiber.c b/src/lib/core/fiber.c > index 00ae8cded..f795dc566 100644 > --- a/src/lib/core/fiber.c > +++ b/src/lib/core/fiber.c > @@ -774,7 +774,7 @@ fiber_self() > void > fiber_gc(void) > { > - if (region_used(&fiber()->gc) < 128 * 1024) { > + if (region_total(&fiber()->gc) < 128 * 1024) { > region_reset(&fiber()->gc); > return; > } >
prev parent reply other threads:[~2020-02-04 21:25 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-27 19:33 Georgy Kirichenko 2020-01-27 20:26 ` Georgy Kirichenko 2020-01-29 21:50 ` Konstantin Osipov 2020-02-04 21:25 ` Vladislav Shpilevoy [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2dccd4ca-9f29-c71d-f49c-da6722a5e743@tarantool.org \ --to=v.shpilevoy@tarantool.org \ --cc=georgy@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH] region: take allocated region size instead of used one' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox