Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: [tarantool-patches] [PATCH v2 3/3] netbox: deprecate console support
Date: Wed, 28 Mar 2018 16:35:50 +0300	[thread overview]
Message-ID: <2db41bb2a2ccd52fbc76b568d887740e4cea2031.1522243429.git.v.shpilevoy@tarantool.org> (raw)
In-Reply-To: <cover.1522243429.git.v.shpilevoy@tarantool.org>
In-Reply-To: <cover.1522243429.git.v.shpilevoy@tarantool.org>

Print warning about that. After a while the cosole support will
be deleted from netbox.
---
 src/box/lua/net_box.lua | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/box/lua/net_box.lua b/src/box/lua/net_box.lua
index 5691dcb9e..0309eef17 100644
--- a/src/box/lua/net_box.lua
+++ b/src/box/lua/net_box.lua
@@ -650,6 +650,11 @@ local function new_sm(host, port, opts, connection, greeting)
     local user, password = opts.user, opts.password; opts.password = nil
     local last_reconnect_error
     local remote = {host = host, port = port, opts = opts, state = 'initial'}
+    -- @deprecated since 1.10
+    if greeting and greeting.protocol == 'Lua console' or opts.console then
+        log.warn("Netbox text protocol support is deprecated since 1.10, "..
+                 "please use require('console').connect() instead")
+    end
     local function callback(what, ...)
         if what == 'state_changed' then
             local state, errno, err = ...
-- 
2.14.3 (Apple Git-98)

      parent reply	other threads:[~2018-03-28 13:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-28 13:35 [tarantool-patches] [PATCH v2 0/3] console: do not use netbox for console text connections Vladislav Shpilevoy
2018-03-28 13:35 ` [tarantool-patches] [PATCH v2 1/3] netbox: allow to create a netbox connection from existing socket Vladislav Shpilevoy
2018-03-29 13:03   ` [tarantool-patches] " Konstantin Osipov
2018-03-28 13:35 ` [tarantool-patches] [PATCH v2 2/3] console: do not use netbox for console text connections Vladislav Shpilevoy
2018-03-29 13:03   ` [tarantool-patches] " Konstantin Osipov
2018-03-28 13:35 ` Vladislav Shpilevoy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2db41bb2a2ccd52fbc76b568d887740e4cea2031.1522243429.git.v.shpilevoy@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [tarantool-patches] [PATCH v2 3/3] netbox: deprecate console support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox