Re: [Tarantool-patches] [PATCH] box: always promote error created via box.error() to diag

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

Thanks for the patch!

On 01/04/2020 17:52, Nikita Pettik wrote:
> Note that it is vital that box.error() now promotes error to diag, since
> otherwise user is unable to set to diag custom error, which in turn is

Why unable? I thought we have box.error.set(). You can always do

    box.error.set(error_object)
    box.error()

This is equivalent of

    box.error(error_object)

which you are doing in this patch.

> linked with other errors:
> 
> e1 = box.error.new({code = 111, reason = "cause"})
> e2 = box.error.new({code = 111, reason = "err"})
> e2:set_prev(e1)
> -- There's no means to set e2 to diagnostic area.

tarantool> e1 = box.error.new({code = 111})
---
...

tarantool> e2 = box.error.new({code = 111})
---
...

tarantool> e2:set_prev(e1)
---
...

tarantool> box.error.set(e2)
---
...

tarantool> box.error.last() == e2
---
- true
...

> This patch makes box.error() always promote error to the diagnostic
> area despite of passed arguments.

But I am not against this patch. It is a nice sugar, when you need to
both set + throw. It is LGTM except the commit message due to comments
above.

> Closes #4829
> 
> @TarantoolBot document
> Title: always promote error created via box.error() to diag
> 
> box.error() is able to accept two types of argument: either pair of code
> + reason (box.error{code = 555, reason = 'Arbitrary message'}) or error
> object (box.error(err)). In the first case error is promoted to
> diagnostic area, meanwhile in the latter - it is not:
> ```
> e1 = box.error.new({code = 111, reason = "cause"})
> box.error({code = 111, reason = "err"})
> - error: err
> box.error.last()
> - err
> box.error(e1)
> - error: cause
> box.error.last()
> - err
> ```
> From now box.error(e1) sets error to diagnostic area as well:
> ```
> box.error(e1)
> - error: cause
> box.error.last()
> - cause
> ```
> ---