From: Imeev Mergen <imeevma@tarantool.org>
To: "n.pettik" <korablev@tarantool.org>, tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v1 1/3] sql: remove mayAbort field from struct Parse
Date: Mon, 22 Apr 2019 10:49:20 +0300 [thread overview]
Message-ID: <2ca61ada-3bc3-5e42-15c2-f24f090c107f@tarantool.org> (raw)
In-Reply-To: <C89F4290-D9FA-4CF0-9FB1-285A1E208D63@tarantool.org>
[-- Attachment #1: Type: text/plain, Size: 1053 bytes --]
Hi! Thank you for review!
On 4/15/19 5:06 PM, n.pettik wrote:
>
>> On 12 Apr 2019, at 15:34, imeevma@tarantool.org wrote:
>>
>> Currently, the mayAbort field is used only in one place in debug
>> mode and is not used in non-debug mode. This patch removes this
>> field.
> Could you be more specific when pointing out the reason of removal?
> What was the feature you are removing and why it can be removed?
> Argument like ‘it is used only in debug mode’ doesn’t seem to be
> convincing enough.
I'll add that this allows us to remove SQL errcode SQL_CONSTRAINT.
>
>> Part of #4074
> Code involved in this patch doesn’t throw any errors,
> so why it is a part of diag replacement?
>
> I guess this code clean-up can be OK, but we must
> be sure that this functionality can’t be applied to our
> SQL implementation.
>
In fact, this code works with the error code SQL_CONSTRAINT, and
if we want to remove this error code, we must think of a way to
replace it with some other similar checks. I think this will make
the code less understandable.
[-- Attachment #2: Type: text/html, Size: 2071 bytes --]
next prev parent reply other threads:[~2019-04-22 7:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 12:34 [tarantool-patches] [PATCH v1 0/3] sql: make SQL_TARANTOOL_ERROR the only errcode of OP_Halt imeevma
2019-04-12 12:34 ` [tarantool-patches] [PATCH v1 1/3] sql: remove mayAbort field from struct Parse imeevma
2019-04-15 14:06 ` [tarantool-patches] " n.pettik
2019-04-22 7:49 ` Imeev Mergen [this message]
2019-04-26 7:25 ` Mergen Imeev
2019-04-28 23:35 ` n.pettik
2019-04-12 12:34 ` [tarantool-patches] [PATCH v1 2/3] sql: rework diag_set() in OP_Halt imeevma
2019-04-15 15:21 ` [tarantool-patches] " n.pettik
2019-04-22 8:24 ` Imeev Mergen
2019-04-24 12:19 ` n.pettik
2019-04-26 7:48 ` Mergen Imeev
2019-04-28 23:35 ` n.pettik
2019-04-29 15:05 ` Imeev Mergen
2019-05-05 11:31 ` Imeev Mergen
2019-04-12 12:34 ` [tarantool-patches] [PATCH v1 3/3] sql: make SQL_TARANTOOL_ERROR the only errcode of OP_Halt imeevma
2019-04-15 15:19 ` [tarantool-patches] " n.pettik
2019-04-22 8:47 ` Imeev Mergen
2019-04-22 9:53 ` Imeev Mergen
2019-04-26 7:37 ` Mergen Imeev
2019-04-28 23:35 ` n.pettik
2019-05-05 12:16 ` Imeev Mergen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ca61ada-3bc3-5e42-15c2-f24f090c107f@tarantool.org \
--to=imeevma@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v1 1/3] sql: remove mayAbort field from struct Parse' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox