From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Cc: Maxim Kokryashkin <max.kokryashkin@gmail.com>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit v5 2/2] test: add tests for debugging extensions
Date: Wed, 20 Dec 2023 15:23:38 +0300 [thread overview]
Message-ID: <2c02e187-ec13-4d3f-8a7f-b45ae4b62d2a@tarantool.org> (raw)
In-Reply-To: <w4pvajwbdlqlvu474adsqroqu6cguwln6aulrvz5zpvre3eaol@y66fnaqtxjvp>
Thanks again, LGTM.
On 12/19/23 17:34, Maxim Kokryashkin wrote:
> Hi!
> Thanks for the review!
> Fixed your comments, except for the comment about CMake policy. The
> policy you've mentioned is too new to include in our CMakeLists.txt.
>
> Branch is force pushed, diff is below:
> ===
<snipped>
prev parent reply other threads:[~2023-12-20 12:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 14:14 [Tarantool-patches] [PATCH luajit v5 0/2] debug: generalized extension Maxim Kokryashkin via Tarantool-patches
2023-12-06 14:14 ` [Tarantool-patches] [PATCH luajit v5 1/2] " Maxim Kokryashkin via Tarantool-patches
2023-12-19 8:01 ` Sergey Bronnikov via Tarantool-patches
2023-12-06 14:14 ` [Tarantool-patches] [PATCH luajit v5 2/2] test: add tests for debugging extensions Maxim Kokryashkin via Tarantool-patches
2023-12-19 8:16 ` Sergey Bronnikov via Tarantool-patches
2023-12-19 14:34 ` Maxim Kokryashkin via Tarantool-patches
2023-12-20 12:23 ` Sergey Bronnikov via Tarantool-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c02e187-ec13-4d3f-8a7f-b45ae4b62d2a@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=m.kokryashkin@tarantool.org \
--cc=max.kokryashkin@gmail.com \
--cc=sergeyb@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit v5 2/2] test: add tests for debugging extensions' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox