From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: sergepetrenko <sergepetrenko@tarantool.org>,
kirichenkoga@gmail.com, kostja.osipov@gmail.com,
alexander.turenko@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v4 0/4] replication: fix applying of rows originating from local instance
Date: Thu, 27 Feb 2020 00:54:50 +0100 [thread overview]
Message-ID: <2b8790c2-b5b9-07c2-3c83-5385e5f6096f@tarantool.org> (raw)
In-Reply-To: <cover.1582709303.git.sergepetrenko@tarantool.org>
Hi! Thanks for the patch!
Please, add a @ChangeLog record.
On 26/02/2020 11:00, sergepetrenko wrote:
> https://github.com/tarantool/tarantool/issues/4739
> https://github.com/tarantool/tarantool/tree/sp/gh-4739-vclock-assert-v4
>
> Changes in v4:
> - move row skipping logic from recovery to relay
> - encode a list of instances whose rows to skip
> in SUBSCRIBE request insead of encoding
> is_orhpan status
>
> Changes in v3:
> - review fixes as per review from Vlad
> - instead of skipping rows on replica side,
> do it on master side, by patching recovery
> to silently follow rows coming from a certain
> instance.
>
> Changes in v2:
> - review fixes as per review from Kostja
>
> Serge Petrenko (4):
> box: expose box_is_orphan method
> wal: warn when trying to write a record with a broken lsn
> replication: implement an instance id filter for relay
> replication: do not relay rows coming from a remote instance back to
> it
>
> src/box/applier.cc | 3 ++-
> src/box/box.cc | 13 +++++++++---
> src/box/box.h | 3 +++
> src/box/iproto_constants.h | 1 +
> src/box/relay.cc | 9 ++++++++-
> src/box/relay.h | 3 ++-
> src/box/wal.c | 17 +++++++++++++---
> src/box/xrow.c | 41 +++++++++++++++++++++++++++++++++++---
> src/box/xrow.h | 34 +++++++++++++++++++++----------
> 9 files changed, 101 insertions(+), 23 deletions(-)
>
next prev parent reply other threads:[~2020-02-26 23:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 10:00 sergepetrenko
2020-02-26 10:00 ` [Tarantool-patches] [PATCH v4 1/4] box: expose box_is_orphan method sergepetrenko
2020-02-26 10:00 ` [Tarantool-patches] [PATCH v4 2/4] wal: warn when trying to write a record with a broken lsn sergepetrenko
2020-02-26 10:00 ` [Tarantool-patches] [PATCH v4 3/4] replication: implement an instance id filter for relay sergepetrenko
2020-02-26 10:18 ` Konstantin Osipov
2020-02-26 11:16 ` Serge Petrenko
2020-02-26 23:54 ` Vladislav Shpilevoy
2020-02-27 6:48 ` Konstantin Osipov
2020-02-27 13:15 ` Serge Petrenko
2020-02-27 23:33 ` Vladislav Shpilevoy
2020-02-26 10:00 ` [Tarantool-patches] [PATCH v4 4/4] replication: do not relay rows coming from a remote instance back to it sergepetrenko
2020-02-26 10:23 ` Konstantin Osipov
2020-02-26 11:21 ` Serge Petrenko
2020-02-26 11:58 ` Konstantin Osipov
2020-02-26 15:58 ` Serge Petrenko
2020-02-26 16:40 ` Konstantin Osipov
2020-02-26 23:54 ` Vladislav Shpilevoy
2020-02-27 6:52 ` Konstantin Osipov
2020-02-27 14:13 ` Serge Petrenko
2020-02-27 21:17 ` Serge Petrenko
2020-02-27 23:22 ` Vladislav Shpilevoy
2020-02-28 8:03 ` Serge Petrenko
2020-02-26 23:54 ` Vladislav Shpilevoy [this message]
2020-02-27 21:24 ` [Tarantool-patches] [PATCH v4 0/4] replication: fix applying of rows originating from local instance Serge Petrenko
2020-02-27 23:24 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b8790c2-b5b9-07c2-3c83-5385e5f6096f@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=kirichenkoga@gmail.com \
--cc=kostja.osipov@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v4 0/4] replication: fix applying of rows originating from local instance' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox