Re: [Tarantool-patches] [PATCH 2/4] uuid: expose additional from_string constructors

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

Hi! Thanks for the fixes!

>> 6 апр. 2020 г., в 00:22, Vladislav Shpilevoy <v.shpilevoy@tarantool.org> написал(а):
>>
>> Thanks for the patch!
>>
>>> diff --git a/src/lib/uuid/tt_uuid.c b/src/lib/uuid/tt_uuid.c
>>> index 1bd2e2cfe..94a0b15bb 100644
>>> --- a/src/lib/uuid/tt_uuid.c
>>> +++ b/src/lib/uuid/tt_uuid.c
>>> @@ -65,6 +65,15 @@ tt_uuid_create(struct tt_uuid *uu)
>>> }
>>> #endif
>>>
>>> +extern inline int
>>
>> 'inline' modifier won't change anything. The function body is
>> not visible anyway.
> 
> Not sure about that.
> What about other functions?
> 
> ```
> extern inline int                                                                   
> tt_uuid_from_string(const char *in, struct tt_uuid *uu);
> ```
> 
> I’m still not sure what ‘extern inline’ does, but I googled a stackoverflow
> question discussing it:
> https://stackoverflow.com/questions/216510/what-does-extern-inline-do

From what I understood by the link above and here: http://m68hc11.serveftp.org/inline-1.php
it looks like 'extern inline' does not make any sense for function
declaration. It should be used only for function definition in a
header file.