[Tarantool-patches] [PATCH v1] gitlab-ci: disable perf tesing in schedulled runs

[Tarantool-patches] [PATCH v1] gitlab-ci: disable perf tesing in schedulled runs

[Alexander V. Tikhonov]

Release branches should be regularly run using gitlab-ci pipeline
schedules:
  https://gitlab.com/tarantool/tarantool/pipeline_schedules
It will help to detect flaky issues. But there is no need to rerun
too long running performance testing, to block it in schedules the
option 'schedules' in 'except:' field was set.

Part of #4974
---

Github: https://github.com/tarantool/tarantool/tree/avtikhon/schedule_except_perf
Issue: https://github.com/tarantool/tarantool/issues/4974

 .gitlab-ci.yml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index c7f58b98d..256b368c4 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -32,6 +32,8 @@ variables:
   only:
     - master
     - /^.*-perf$/
+  except:
+    - schedules
   variables: &perf_vars_definition
     IMAGE_PERF: "${CI_REGISTRY}/${CI_PROJECT_PATH}/perf/ubuntu-bionic:perf_master"
     IMAGE_PERF_BUILT: "${CI_REGISTRY}/${CI_PROJECT_PATH}/perf_tmp/ubuntu-bionic:perf_${CI_COMMIT_SHORT_SHA}"
-- 
2.17.1

Re: [Tarantool-patches] [PATCH v1] gitlab-ci: disable perf tesing in schedulled runs

[Sergey Bronnikov]

Alexander, thanks for the patch.
Please fix typo in commit message: schedulled -> scheduled.

LGTM

On 13:29 Thu 14 May , Alexander V. Tikhonov wrote:
> Release branches should be regularly run using gitlab-ci pipeline
> schedules:
>   https://gitlab.com/tarantool/tarantool/pipeline_schedules
> It will help to detect flaky issues. But there is no need to rerun
> too long running performance testing, to block it in schedules the
> option 'schedules' in 'except:' field was set.
> 
> Part of #4974
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/schedule_except_perf
> Issue: https://github.com/tarantool/tarantool/issues/4974
> 
>  .gitlab-ci.yml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index c7f58b98d..256b368c4 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -32,6 +32,8 @@ variables:
>    only:
>      - master
>      - /^.*-perf$/
> +  except:
> +    - schedules
>    variables: &perf_vars_definition
>      IMAGE_PERF: "${CI_REGISTRY}/${CI_PROJECT_PATH}/perf/ubuntu-bionic:perf_master"
>      IMAGE_PERF_BUILT: "${CI_REGISTRY}/${CI_PROJECT_PATH}/perf_tmp/ubuntu-bionic:perf_${CI_COMMIT_SHORT_SHA}"
> -- 
> 2.17.1

Re: [Tarantool-patches] [PATCH v1] gitlab-ci: disable perf tesing in schedulled runs

[Oleg Piskunov]

[-- Attachment #1: Type: text/plain, Size: 1200 bytes --]


LGTM

  
>Четверг, 14 мая 2020, 13:29 +03:00 от Alexander V. Tikhonov <avtikhon@tarantool.org>:
> 
>Release branches should be regularly run using gitlab-ci pipeline
>schedules:
>   https://gitlab.com/tarantool/tarantool/pipeline_schedules
>It will help to detect flaky issues. But there is no need to rerun
>too long running performance testing, to block it in schedules the
>option 'schedules' in 'except:' field was set.
>
>Part of #4974
>---
>
>Github:  https://github.com/tarantool/tarantool/tree/avtikhon/schedule_except_perf
>Issue:  https://github.com/tarantool/tarantool/issues/4974
>
> .gitlab-ci.yml | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>index c7f58b98d..256b368c4 100644
>--- a/.gitlab-ci.yml
>+++ b/.gitlab-ci.yml
>@@ -32,6 +32,8 @@ variables:
>   only:
>     - master
>     - /^.*-perf$/
>+ except:
>+ - schedules
>   variables: &perf_vars_definition
>     IMAGE_PERF: "${CI_REGISTRY}/${CI_PROJECT_PATH}/perf/ubuntu-bionic:perf_master"
>     IMAGE_PERF_BUILT: "${CI_REGISTRY}/${CI_PROJECT_PATH}/perf_tmp/ubuntu-bionic:perf_${CI_COMMIT_SHORT_SHA}"
>--
>2.17.1
>  
 
 
--
Oleg Piskunov
 

[-- Attachment #2: Type: text/html, Size: 2094 bytes --]

Re: [Tarantool-patches] [PATCH v1] gitlab-ci: disable perf tesing in schedulled runs

[Kirill Yukhin]

Hello,

On 14 май 13:29, Alexander V. Tikhonov wrote:
> Release branches should be regularly run using gitlab-ci pipeline
> schedules:
>   https://gitlab.com/tarantool/tarantool/pipeline_schedules
> It will help to detect flaky issues. But there is no need to rerun
> too long running performance testing, to block it in schedules the
> option 'schedules' in 'except:' field was set.
> 
> Part of #4974
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/schedule_except_perf
> Issue: https://github.com/tarantool/tarantool/issues/4974

I've checked your patch into 1.10, 2.3, 2.4 and master.

--
Regards, Kirill Yukhin