From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Cc: Maxim Kokryashkin <max.kokryashkin@gmail.com>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] Fix frame for on-trace out-of-memory error.
Date: Tue, 12 Sep 2023 12:53:40 +0300 [thread overview]
Message-ID: <2a8e8bc3-7287-9321-4168-f89191c3272a@tarantool.org> (raw)
In-Reply-To: <67yxwvlqg25jcdc5kfot73j54l7bsddcs22cht54cqlj32muca@ri5nczyzho6d>
Hi,
On 9/8/23 16:18, Maxim Kokryashkin wrote:
> Hi, Sergey!
> Thanks for the review!
> See my answers below.
>
Thanks for update!
In version on the branch I see that function test_finalizers called twice.
Let's add a comment with explanation for this.
LGTM
Sergey
next prev parent reply other threads:[~2023-09-12 9:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 10:39 [Tarantool-patches] [PATCH luajit 0/2] Fix frames for on trace errors Maxim Kokryashkin via Tarantool-patches
2023-09-05 10:39 ` [Tarantool-patches] [PATCH luajit 1/2] Fix frame for on-trace out-of-memory error Maxim Kokryashkin via Tarantool-patches
2023-09-07 8:07 ` Sergey Bronnikov via Tarantool-patches
2023-09-08 13:18 ` Maxim Kokryashkin via Tarantool-patches
2023-09-12 9:53 ` Sergey Bronnikov via Tarantool-patches [this message]
2023-09-11 8:04 ` Sergey Kaplun via Tarantool-patches
2023-09-11 11:52 ` Maxim Kokryashkin via Tarantool-patches
2023-09-05 10:39 ` [Tarantool-patches] [PATCH luajit 2/2] Fix frame for more types of on-trace error messages Maxim Kokryashkin via Tarantool-patches
2023-09-07 8:11 ` Sergey Bronnikov via Tarantool-patches
2023-09-07 8:56 ` Maxim Kokryashkin via Tarantool-patches
2023-09-07 10:06 ` Sergey Bronnikov via Tarantool-patches
2023-09-11 8:20 ` Sergey Kaplun via Tarantool-patches
2023-09-11 13:45 ` Maxim Kokryashkin via Tarantool-patches
2023-09-27 12:33 ` [Tarantool-patches] [PATCH luajit 0/2] Fix frames for on trace errors Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a8e8bc3-7287-9321-4168-f89191c3272a@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=m.kokryashkin@tarantool.org \
--cc=max.kokryashkin@gmail.com \
--cc=sergeyb@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 1/2] Fix frame for on-trace out-of-memory error.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox