Re: [Tarantool-patches] [PATCH luajit 3/4][v2] OSX/iOS/ARM64: Fix generation of Mach-O object files.

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 1144 bytes --]

Sergey,

On 16.04.2024 18:29, Sergey Bronnikov via Tarantool-patches wrote:
<snipped>
>> Minor: we can use `subtest.name` as the definition of the `hw_arch` in the
>> `build_and_check_mach_o()`, so it helps to avoid duplication of arch
>> usage.
>>
>> Matter of taste.
>> Feel free to ignore.
> ignored

removed additional argument with `hw_arch` and replaced with subtest.name:


@@ -293,7 +295,8 @@ local SUM_CPUSUBTYPE = {
  -- $ luajit -b -o osx -a arm64 empty.lua empty.o
  -- $ lipo -archs empty.o
  -- x86_64 arm64
-local function build_and_check_mach_o(subtest, hw_arch)
+local function build_and_check_mach_o(subtest)
+  local hw_arch = subtest.name
    assert(hw_arch == 'arm' or hw_arch == 'arm64')

    subtest:plan(4)
@@ -341,7 +344,7 @@ local function build_and_check_mach_o(subtest, hw_arch)
               'cpusubtype is correct in Mach-O')
  end

-test:test('arm', build_and_check_mach_o, 'arm')
-test:test('arm64', build_and_check_mach_o, 'arm64')
+test:test('arm', build_and_check_mach_o)
+test:test('arm64', build_and_check_mach_o)

  test:done(true)

>>> +
>>> +test:done(true)
>>> -- 
>>> 2.34.1
>>>

[-- Attachment #2: Type: text/html, Size: 2524 bytes --]