From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E25B0BB2A2F; Thu, 13 Jun 2024 18:50:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E25B0BB2A2F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1718293850; bh=T5KEj1349BFO1gxkF6NcRSbSVhCNvDPO9etWLpYShVQ=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=f1K7nBdkcJM1CWvtgdWcdt8gkvBFbvO/4eyLuo2L83PiaZJLtdl8koCa3+K4Z6twj gUeEryUhmirPB591quGhb7qp5Xyl4VIIc54xm7DT70UNcb3USh8cJ1n+osAzqs2k+3 gGIQ8nH6Ezgrtw9nYvOuDwoaEwmtpM75iD7hofVU= Received: from smtp39.i.mail.ru (smtp39.i.mail.ru [95.163.41.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E9B39BB2A2B for ; Thu, 13 Jun 2024 18:50:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E9B39BB2A2B Received: by smtp39.i.mail.ru with esmtpa (envelope-from ) id 1sHmiu-0000000BwlQ-00ke; Thu, 13 Jun 2024 18:50:48 +0300 Content-Type: multipart/alternative; boundary="------------Fs3hY24C2o1jdZOqq5yndgbh" Message-ID: <2a32d622-cbeb-46f3-8dd7-aaa6f1daf7a2@tarantool.org> Date: Thu, 13 Jun 2024 18:50:47 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun , Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org References: <7bdffd2650a785877e03584e6d532e855d09de8a.1712841312.git.sergeyb@tarantool.org> <052764ac-c566-4551-81e0-777c60cc7845@tarantool.org> In-Reply-To: <052764ac-c566-4551-81e0-777c60cc7845@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9AC8CA0B4439200FA3396D26EA105C0471DE01117BA8131F700894C459B0CD1B963F063D9A6E6F4B3B4E7C6DD6280A795815A6FD06C9C4466845E84994076374FCE06B70447BA4CE8 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7BF6699A3AA9BACA6EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006372BE3E2E75E3847F48638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D862959973544A039B2BBEC517A67B1B71285A8FFCCFA0564ACC7F00164DA146DAFE8445B8C89999728AA50765F790063741F7343E26298569389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC817119E5299B287EEF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C4E7D9683544204AFC0837EA9F3D197644AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3F6D1C8D476B9D508BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE7AEA1580DED4E70E3731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5C77CC68DCDEB0A475002B1117B3ED696333F7DB83008AB8914DB8790748E3E77823CB91A9FED034534781492E4B8EEAD5B606B10FC07407CBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF75909176FE5A0C0703632E07F47A1715ECC23100E1D85BB3DF3E6874FA9F8E76245B1B6CBED8166A04A26A3878DC13300F03D24CBD13B77C1A398D8D4246AB712DCD8F391FF8DD285F4332CA8FE04980913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojP/c/PTD82AmslFI8pMF0nA== X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D614063F063D9A6E6F4B3B4E7C6DD6280A795A07053E854A7C95C0152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 3/4][v2] OSX/iOS/ARM64: Fix generation of Mach-O object files. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------Fs3hY24C2o1jdZOqq5yndgbh Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sergey, On 16.04.2024 18:29, Sergey Bronnikov via Tarantool-patches wrote: >> Minor: we can use `subtest.name` as the definition of the `hw_arch` in the >> `build_and_check_mach_o()`, so it helps to avoid duplication of arch >> usage. >> >> Matter of taste. >> Feel free to ignore. > ignored removed additional argument with `hw_arch` and replaced with subtest.name: @@ -293,7 +295,8 @@ local SUM_CPUSUBTYPE = {  -- $ luajit -b -o osx -a arm64 empty.lua empty.o  -- $ lipo -archs empty.o  -- x86_64 arm64 -local function build_and_check_mach_o(subtest, hw_arch) +local function build_and_check_mach_o(subtest) +  local hw_arch = subtest.name    assert(hw_arch == 'arm' or hw_arch == 'arm64')    subtest:plan(4) @@ -341,7 +344,7 @@ local function build_and_check_mach_o(subtest, hw_arch)               'cpusubtype is correct in Mach-O')  end -test:test('arm', build_and_check_mach_o, 'arm') -test:test('arm64', build_and_check_mach_o, 'arm64') +test:test('arm', build_and_check_mach_o) +test:test('arm64', build_and_check_mach_o)  test:done(true) >>> + >>> +test:done(true) >>> -- >>> 2.34.1 >>> --------------Fs3hY24C2o1jdZOqq5yndgbh Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Sergey,

On 16.04.2024 18:29, Sergey Bronnikov via Tarantool-patches wrote:
<snipped>
Minor: we can use `subtest.name` as the definition of the `hw_arch` in the
`build_and_check_mach_o()`, so it helps to avoid duplication of arch
usage.

Matter of taste.
Feel free to ignore.
ignored

removed additional argument with `hw_arch` and replaced with subtest.name:


@@ -293,7 +295,8 @@ local SUM_CPUSUBTYPE = {
 -- $ luajit -b -o osx -a arm64 empty.lua empty.o
 -- $ lipo -archs empty.o
 -- x86_64 arm64
-local function build_and_check_mach_o(subtest, hw_arch)
+local function build_and_check_mach_o(subtest)
+  local hw_arch = subtest.name
   assert(hw_arch == 'arm' or hw_arch == 'arm64')
 
   subtest:plan(4)
@@ -341,7 +344,7 @@ local function build_and_check_mach_o(subtest, hw_arch)
              'cpusubtype is correct in Mach-O')
 end
 
-test:test('arm', build_and_check_mach_o, 'arm')
-test:test('arm64', build_and_check_mach_o, 'arm64')
+test:test('arm', build_and_check_mach_o)
+test:test('arm64', build_and_check_mach_o)
 
 test:done(true)

+
+test:done(true)
-- 
2.34.1
--------------Fs3hY24C2o1jdZOqq5yndgbh--