Tarantool development patches archive
 help / color / mirror / Atom feed
From: Serge Petrenko <sergepetrenko@tarantool.org>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: Georgy Kirichenko <georgy@tarantool.org>,
	tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] Re: [PATCH v2] replication: do not ignore replication_connect_quorum.
Date: Thu, 9 Aug 2018 15:39:26 +0300	[thread overview]
Message-ID: <2DC61B5A-36F2-4F4B-8190-FD09E5BD9F50@tarantool.org> (raw)
In-Reply-To: <20180809122011.azcmyh5qnuipm3uh@esperanza>



> 9 авг. 2018 г., в 15:20, Vladimir Davydov <vdavydov.dev@gmail.com> написал(а):
> 
> On Thu, Aug 09, 2018 at 12:11:01PM +0300, Vladimir Davydov wrote:
>>>>> diff --git a/test/replication-py/master.lua b/test/replication-py/master.lua
>>>>> index 0f9f7a6f0..51283efdf 100644
>>>>> --- a/test/replication-py/master.lua
>>>>> +++ b/test/replication-py/master.lua
>>>>> @@ -3,6 +3,8 @@ os = require('os')
>>>>> box.cfg({
>>>>>    listen              = os.getenv("LISTEN"),
>>>>>    memtx_memory        = 107374182,
>>>>> +    replication_connect_timeout = 1.0,
>>>>> +    replication_timeout = 0.3
>>>> 
>>>> Why do you need to adjust the timeouts?
>>> 
>>> The timeouts set in all cfg files in all the tests had no effect, just like the
>>> replication_connect_quorum option, cos both of the options were ignored
>>> During bootstrap. We wanted every replica to connect, and the timeout was
>>> Set to TIMEOUT_INFINITY. Now when we actually start passing
>>> replication_connect_timeout, all these timeouts become too small.
>> 
>> Some tests now take too long because of this. E.g. replication/quorum
>> runs for 15 seconds for memtx+vinyl without this patch, which is already
>> long enough, but with this patch it takes more than 30 seconds. We need
>> to do something about that.
> 
> May be, we could pass replication_connect_timeout to these scripts
> in arguments and use different timeouts for bootstrap and subsequent
> restarts?
> 

Yeah, this makes sense. Will try.
I tried to fix replication/quorum, but could only
decrease the time to 22 seconds on memtx + vinyl, and the test wasn’t stable.

  reply	other threads:[~2018-08-09 12:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-07 12:44 [tarantool-patches] " Serge Petrenko
2018-08-07 14:18 ` [tarantool-patches] " Georgy Kirichenko
2018-08-07 17:28 ` [tarantool-patches] " Vladimir Davydov
2018-08-09  7:50   ` [tarantool-patches] " Sergey Petrenko
2018-08-09  9:11     ` Vladimir Davydov
2018-08-09 12:20       ` Vladimir Davydov
2018-08-09 12:39         ` Serge Petrenko [this message]
2018-08-10  9:14           ` [PATCH v3] " Serge Petrenko
2018-08-10 10:48             ` Vladimir Davydov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2DC61B5A-36F2-4F4B-8190-FD09E5BD9F50@tarantool.org \
    --to=sergepetrenko@tarantool.org \
    --cc=georgy@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [tarantool-patches] Re: [PATCH v2] replication: do not ignore replication_connect_quorum.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox