From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Konstantin Osipov <kostja@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] sql: fix type in meta for unsigned binding
Date: Wed, 24 Jul 2019 20:44:34 +0300 [thread overview]
Message-ID: <2D87D431-5106-4599-8AB9-ABFD66B99EA2@tarantool.org> (raw)
In-Reply-To: <20190724171007.GB4764@atlas>
> On 24 Jul 2019, at 20:10, Konstantin Osipov <kostja@tarantool.org> wrote:
>
> * Nikita Pettik <korablev@tarantool.org> [19/07/24 19:59]:
>> It was decided that for all integer literals we would return "INTEGER"
>> type, not "UNSIGNED". Accidentally, after substitution of unsigned
>> binding value type was set to "UNSIGNED". Let's fix that and set
>> "INTEGER" type.
>
> the patch is lgtm but I'm not sure it covers all cases.
>
> I've seen a lot of unsigned inthe tests.
I see only one more unsigned appearance:
box.execute("SELECT CAST('123' AS UNSIGNED);")
---
- metadata:
- name: CAST('123' AS UNSIGNED)
type: unsigned
rows:
- [123]
…
But I guess in this case user would be less surprised
if one saw unsigned type than integer.
> --
> Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-07-24 17:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 16:55 [tarantool-patches] " Nikita Pettik
2019-07-24 17:10 ` [tarantool-patches] " Konstantin Osipov
2019-07-24 17:44 ` n.pettik [this message]
2019-07-24 18:23 ` Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2D87D431-5106-4599-8AB9-ABFD66B99EA2@tarantool.org \
--to=korablev@tarantool.org \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] sql: fix type in meta for unsigned binding' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox