From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Ivan Koptelov <ivan.koptelov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] sql: remove tests on stmts with 'db table'
Date: Thu, 7 Feb 2019 21:52:43 +0300 [thread overview]
Message-ID: <2B6FCFC5-F098-4E97-98D8-7E052D77E842@tarantool.org> (raw)
In-Reply-To: <20190207181742.85150-1-ivan.koptelov@tarantool.org>
> On 7 Feb 2019, at 21:17, Ivan Koptelov <ivan.koptelov@tarantool.org> wrote:
>
> We don't have such functionality, but some legacy tests were
> existed (disabled).
Do you checked all test files, or only e_delete.test.lua?
If the latter is the case, mention it in commit message/subject.
AFAIR we had a lot of similar tests in our test suite; I am not
sure about current status of such tests.
Otherwise, it sounds like you cleaned up all our test suite.
Then LGTM.
next prev parent reply other threads:[~2019-02-07 18:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 18:17 [tarantool-patches] " Ivan Koptelov
2019-02-07 18:52 ` n.pettik [this message]
2019-02-07 19:19 ` i.koptelov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2B6FCFC5-F098-4E97-98D8-7E052D77E842@tarantool.org \
--to=korablev@tarantool.org \
--cc=ivan.koptelov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] sql: remove tests on stmts with '\''db table'\''' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox