Tarantool development patches archive
 help / color / mirror / Atom feed
From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v6 3/4] sql: space_def* instead of Table* in Expr
Date: Fri, 18 May 2018 20:04:26 +0300	[thread overview]
Message-ID: <2B2A74BE-9817-4296-B7EA-DFE1A1AFD8F3@tarantool.org> (raw)
In-Reply-To: <23e5e1f9-3700-26b4-c974-1b0379dc9bcb@tarantool.org>


>> Probably, you have missed some word (‘use’, ‘replace’ or whatever)
>> 
>> Sorry, but I can’t parse this commit message. Lets dive a little bit into details
>> and explain what this patch *really* does. Such as:
>> “Move affinity filed to struct field in order to bla-bla”.
>> 
>> The rest is almost okay, a few minor remarks.
> ```
>    sql: space_def* instead of Table* in Expr

This message still lacks a verb. Such as:
sql: use space_def* instead Table* in Expr
OR
sql: replace Table* with space_def* in Expr

> 
>    Changed Table pointer to space_def in Expr structure.
>    This makes able to resolve self reference in DDL before

I guess, you lost ’t’ or smth else..

>> Wait, why did you delete assert which had been introduced in the previous patch?
> Because I've changed func. prototype.

Well, I mean anyway these patches come together, so it makes no sense
to fix code (especially asserts) introduced in n-th commit by code in (n+1)-th -
it is just redundant diff (in most cases).

  reply	other threads:[~2018-05-18 17:04 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-15 17:03 [tarantool-patches] [PATCH v6 0/4] sql: moved Checks to server Kirill Shcherbatov
2018-05-15 17:03 ` [tarantool-patches] [PATCH v6 1/4] sql: fix code style in sqlite3Pragma Kirill Shcherbatov
2018-05-15 17:03 ` [tarantool-patches] [PATCH v6 2/4] sql: remove SQL fields from Table and Column Kirill Shcherbatov
2018-05-17 17:25   ` [tarantool-patches] " n.pettik
2018-05-18 15:35     ` Kirill Shcherbatov
2018-05-18 17:24       ` n.pettik
2018-05-18 19:45         ` Kirill Shcherbatov
2018-05-18 20:13           ` n.pettik
2018-05-15 17:03 ` [tarantool-patches] [PATCH v6 3/4] sql: space_def* instead of Table* in Expr Kirill Shcherbatov
2018-05-16 12:33   ` [tarantool-patches] " Vladislav Shpilevoy
2018-05-16 13:10     ` Kirill Shcherbatov
2018-05-16 13:11       ` Vladislav Shpilevoy
     [not found]   ` <26E4269B-2BCB-42C3-8216-D51E290E4723@corp.mail.ru>
2018-05-18 15:26     ` Kirill Shcherbatov
2018-05-18 17:04       ` n.pettik [this message]
2018-05-21 12:48       ` [tarantool-patches] " Nikita Pettik
2018-05-15 17:03 ` [tarantool-patches] [PATCH v6 4/4] sql: remove Checks to server Kirill Shcherbatov
2018-05-16 17:59   ` [tarantool-patches] " Vladislav Shpilevoy
2018-05-16 11:52 ` [tarantool-patches] Re: [PATCH v6 0/4] sql: moved " Vladislav Shpilevoy
2018-05-16 13:13   ` Kirill Shcherbatov
2018-05-23  5:19 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2B2A74BE-9817-4296-B7EA-DFE1A1AFD8F3@tarantool.org \
    --to=korablev@tarantool.org \
    --cc=kshcherbatov@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v6 3/4] sql: space_def* instead of Table* in Expr' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox