[tarantool-patches] Re: [PATCH v6 3/4] sql: space_def* instead of Table* in Expr

["n.pettik" <korablev@tarantool.org>]

>> Probably, you have missed some word (‘use’, ‘replace’ or whatever)
>> 
>> Sorry, but I can’t parse this commit message. Lets dive a little bit into details
>> and explain what this patch *really* does. Such as:
>> “Move affinity filed to struct field in order to bla-bla”.
>> 
>> The rest is almost okay, a few minor remarks.
> ```
>    sql: space_def* instead of Table* in Expr

This message still lacks a verb. Such as:
sql: use space_def* instead Table* in Expr
OR
sql: replace Table* with space_def* in Expr

> 
>    Changed Table pointer to space_def in Expr structure.
>    This makes able to resolve self reference in DDL before

I guess, you lost ’t’ or smth else..

>> Wait, why did you delete assert which had been introduced in the previous patch?
> Because I've changed func. prototype.

Well, I mean anyway these patches come together, so it makes no sense
to fix code (especially asserts) introduced in n-th commit by code in (n+1)-th -
it is just redundant diff (in most cases).