From: Imeev Mergen <imeevma@tarantool.org>
To: "n.pettik" <korablev@tarantool.org>, tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v1 2/3] sql: remove unused macros in SQL
Date: Thu, 11 Apr 2019 19:56:31 +0300 [thread overview]
Message-ID: <29f798a5-3487-0723-0219-6648897d98c6@tarantool.org> (raw)
In-Reply-To: <E0CAB039-E184-464C-A106-87F0AF79EC01@tarantool.org>
Hi! Thank you for review! My answers below.
On 4/11/19 3:08 AM, n.pettik wrote:
>
>> On 9 Apr 2019, at 20:17, imeevma@tarantool.org wrote:
>>
>> Thise macros unused and should be removed.
> Nit: these.
>
> Nit: are unused.
Thanks, will fix.
>
> Are you sure that you’ve removed *all* unused macros?
> Otherwise, which attribute are you used to spot this group
> of macros?
Definitely not all. I started with main.c. Should I remove all
unused macros or just add to the commit-message that these macros
are from main.c?
next prev parent reply other threads:[~2019-04-11 16:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 17:17 [tarantool-patches] [PATCH v1 0/3] sql: remove unused code from SQL imeevma
2019-04-09 17:17 ` [tarantool-patches] [PATCH v1 1/3] sql: remove legacy.c imeevma
2019-04-10 7:26 ` [tarantool-patches] " Konstantin Osipov
2019-04-11 0:02 ` n.pettik
2019-04-09 17:17 ` [tarantool-patches] [PATCH v1 2/3] sql: remove unused macros in SQL imeevma
2019-04-10 7:28 ` [tarantool-patches] " Konstantin Osipov
2019-04-11 0:08 ` n.pettik
2019-04-11 16:56 ` Imeev Mergen [this message]
2019-04-12 13:08 ` Mergen Imeev
2019-04-22 15:39 ` n.pettik
2019-04-23 8:59 ` Kirill Yukhin
2019-04-09 17:17 ` [tarantool-patches] [PATCH v1 3/3] sql: remove unused functions from main.c imeevma
2019-04-10 7:31 ` [tarantool-patches] " Konstantin Osipov
2019-04-11 0:24 ` n.pettik
2019-04-11 6:36 ` Konstantin Osipov
2019-04-11 0:14 ` n.pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29f798a5-3487-0723-0219-6648897d98c6@tarantool.org \
--to=imeevma@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v1 2/3] sql: remove unused macros in SQL' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox