From: Georgy Kirichenko <georgy@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Ilya Markov <imarkov@tarantool.org>
Subject: [tarantool-patches] Re: Fwd: [patches] [log 2/2] say: Fix log_rotate
Date: Thu, 29 Mar 2018 11:23:37 +0300 [thread overview]
Message-ID: <2949639.NBXie4y127@home.lan> (raw)
In-Reply-To: <1522224370.984371501@f506.i.mail.ru>
[-- Attachment #1: Type: text/plain, Size: 376 bytes --]
Please sent all messages bounded as a tree.
A cover message should include issue description
See some comment bellow.
On Wednesday, March 28, 2018 11:06:10 AM MSK Ilya Markov wrote:
> - if (log->type != SAY_LOGGER_FILE) {
> + if (pm_atomic_load(&log->type) != SAY_LOGGER_FILE)
> return 0;
I am not sure you really need to use atomic. What the case you are trying to
fix?
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-03-29 8:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 8:06 [tarantool-patches] " Ilya Markov
2018-03-29 8:23 ` Georgy Kirichenko [this message]
2018-03-29 11:17 ` [tarantool-patches] Re[2]: " Ilya Markov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2949639.NBXie4y127@home.lan \
--to=georgy@tarantool.org \
--cc=imarkov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: Fwd: [patches] [log 2/2] say: Fix log_rotate' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox