From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>,
gorcunov@gmail.com, kostja.osipov@gmail.com
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 1/2] wal: fix tx boundaries
Date: Fri, 29 May 2020 00:53:59 +0200 [thread overview]
Message-ID: <280a2b74-dbad-9cee-decf-abfb01b2894b@tarantool.org> (raw)
In-Reply-To: <89a689f86a2d81e9fcd424375ef6d71432b2d720.1590403792.git.sergepetrenko@tarantool.org>
Thanks for the patch!
> diff --git a/src/box/wal.c b/src/box/wal.c
> index b979244e3..ef4d84920 100644
> --- a/src/box/wal.c
> +++ b/src/box/wal.c
> @@ -956,25 +956,37 @@ wal_assign_lsn(struct vclock *vclock_diff, struct vclock *base,
> struct xrow_header **end)
> {
> int64_t tsn = 0;
> + struct xrow_header **start = row;
> + struct xrow_header **first_glob_row = row;
> /** Assign LSN to all local rows. */
> for ( ; row < end; row++) {
> if ((*row)->replica_id == 0) {
> /*
> * All rows representing local space data
> - * manipulations are signed wth a zero
> + * manipulations are signed with a zero
> * instance id. This is also true for
> * anonymous replicas, since they are
> * only capable of writing to local and
> * temporary spaces.
> */
> - if ((*row)->group_id != GROUP_LOCAL)
> + if ((*row)->group_id != GROUP_LOCAL) {
> (*row)->replica_id = instance_id;
> + }
Seems like accidental diff.
next prev parent reply other threads:[~2020-05-28 22:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 10:58 [Tarantool-patches] [PATCH v2 0/2] fix replication tx boundaries after local space rework Serge Petrenko
2020-05-25 10:58 ` [Tarantool-patches] [PATCH v2 1/2] wal: fix tx boundaries Serge Petrenko
2020-05-28 22:53 ` Vladislav Shpilevoy [this message]
2020-05-29 11:09 ` Serge Petrenko
2020-05-25 10:58 ` [Tarantool-patches] [PATCH v2 2/2] wal: reorder tx rows so that a tx ends on a global row Serge Petrenko
2020-05-25 15:13 ` Cyrill Gorcunov
2020-05-25 16:34 ` Konstantin Osipov
2020-05-25 18:35 ` Cyrill Gorcunov
2020-05-25 20:42 ` Konstantin Osipov
2020-05-26 9:41 ` Serge Petrenko
2020-05-26 11:41 ` Konstantin Osipov
2020-05-26 12:08 ` Serge Petrenko
2020-05-28 22:54 ` Vladislav Shpilevoy
2020-05-29 8:13 ` Konstantin Osipov
2020-05-29 11:42 ` Serge Petrenko
2020-05-29 11:51 ` Konstantin Osipov
2020-05-29 12:07 ` Cyrill Gorcunov
2020-05-29 12:07 ` Cyrill Gorcunov
2020-05-29 12:15 ` Serge Petrenko
2020-05-29 13:44 ` Konstantin Osipov
2020-05-29 15:55 ` Serge Petrenko
2020-06-01 13:40 ` Vladislav Shpilevoy
2020-06-01 16:02 ` Sergey Ostanevich
2020-06-01 17:06 ` Vladislav Shpilevoy
2020-05-28 22:53 ` [Tarantool-patches] [PATCH v2 0/2] fix replication tx boundaries after local space rework Vladislav Shpilevoy
2020-05-29 11:03 ` Serge Petrenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=280a2b74-dbad-9cee-decf-abfb01b2894b@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=kostja.osipov@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 1/2] wal: fix tx boundaries' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox