From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] box: rfc for stacked diagnostic area
Date: Tue, 28 Jan 2020 01:23:36 +0100 [thread overview]
Message-ID: <2807ea8a-9251-0191-3321-6c87a4c5bb09@tarantool.org> (raw)
In-Reply-To: <20200127112337.GE1144@tarantool.org>
Hi! Thanks for the fixes!
It is not a second review. I just wanted to say that I am
going to spend less time on reviewes to the end of this
week due to intensive preparations to FOSDEM. I will get
back to this RFC as soon as I can, I didn't forget.
Just one comment for now, below.
>>> +* **Issues**: [#1148](https://github.com/tarantool/<repository\>/issues/1148)
>>> +
>>
>> 2. You missed 'Summary' section.
>
> I believe it is redundant for such brief RFC.
>
Nevertheless, please, add it. If that RFC is so simpler,
then it should not be a problem to make it match the
RFC template. Template says:
"Short description what, why and how is implemented."
So just say something like
The document describes a stacked diagnostics feature. The
feature is needed for the cases, when there is a complex and
big callstack with different subsystems in it, and sometimes
the most lowlevel error is not descriptive enough. So it is
wanted to be able to look at errors along the whole callstack
from the place where a first error happened. The feature
implementation is going to change a fiber's error object to a
list of objects, a stack. Its first element will always be
created by the deepest and the most basic errors.
Or anything you think would be better here.
next prev parent reply other threads:[~2020-01-28 0:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 20:16 Nikita Pettik
2020-01-22 13:54 ` Nikita Pettik
2020-01-22 23:07 ` Vladislav Shpilevoy
2020-01-23 22:56 ` Vladislav Shpilevoy
2020-01-27 11:23 ` Nikita Pettik
2020-01-28 0:23 ` Vladislav Shpilevoy [this message]
2020-01-29 14:36 ` Nikita Pettik
2020-02-04 20:48 ` Vladislav Shpilevoy
2020-02-05 6:16 ` Nikita Pettik
2020-02-05 22:07 ` Vladislav Shpilevoy
2020-02-06 17:24 ` Nikita Pettik
2020-02-06 20:48 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2807ea8a-9251-0191-3321-6c87a4c5bb09@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] box: rfc for stacked diagnostic area' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox