From: "Maxim Melentiev" <dmarc-noreply@freelists.org> (Redacted sender "m.melentiev" for DMARC)
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org, alexander.turenko@tarantool.org
Subject: [tarantool-patches] Re: [PATCH] Enable support for NOTIFY_SOCKET on macOS
Date: Thu, 22 Aug 2019 11:59:22 +0300 [thread overview]
Message-ID: <27beb551-6221-6e7e-5bba-61802782fe41@corp.mail.ru> (raw)
In-Reply-To: <20190821155200.GA7926@atlas>
Does this work as you expect? Is there any reason to expose
HAVE_MSG_NOSIGNAL to C code?
option(WITH_NOTIFY_SOCKET "Enable notifications on NOTIFY_SOCKET" ON)
if (WITH_SYSTEMD AND NOT WITH_NOTIFY_SOCKET)
message(FATAL_ERROR "WITH_NOTIFY_SOCKET must be enabled when
WITH_SYSTEMD enabled")
endif()
if (WITH_NOTIFY_SOCKET)
# Linux supports MSG_NOSIGNAL flag for sendmsg.
# macOS lacks it, but has SO_NOSIGPIPE for setsockopt
# to achieve same behavior.
CHECK_C_SOURCE_COMPILES("
#include <sys/types.h>
#include <sys/socket.h>
int main(){ return MSG_NOSIGNAL; }
" HAVE_MSG_NOSIGNAL)
CHECK_C_SOURCE_COMPILES("
#include <sys/types.h>
#include <sys/socket.h>
int main(){ return SO_NOSIGPIPE; }
" HAVE_SO_NOSIGPIPE)
if (NOT HAVE_MSG_NOSIGNAL AND NOT HAVE_SO_NOSIGPIPE)
message(FATAL_ERROR
"No way to block SIGPIPE in sendmsg. Can not compile with
WITH_NOTIFY_SOCKET"
)
endif()
endif()
And C code uses #ifdef SO_NOSIGPIP, #ifdef MSG_NOSIGNAL
On 21/08/2019 18:52, Konstantin Osipov wrote:
> * Maxim Melentiev <m.melentiev@corp.mail.ru> [19/08/21 11:32]:
>
> this doesn't address my review.
>
> If you disagree with the review, please reply to it. Otherwise
> there is no point in sending a new patch.
>
next prev parent reply other threads:[~2019-08-22 8:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 8:28 [tarantool-patches] " Max Melentiev
2019-08-19 19:33 ` [tarantool-patches] " Alexander Turenko
2019-08-21 8:31 ` Maxim Melentiev
2019-08-21 15:52 ` Konstantin Osipov
2019-08-22 8:59 ` Maxim Melentiev [this message]
2019-08-22 10:06 ` Konstantin Osipov
2019-08-22 12:44 ` Maxim Melentiev
2019-08-22 13:03 ` Konstantin Osipov
2019-08-22 14:27 ` Maxim Melentiev
2019-08-23 12:11 ` Alexander Turenko
2019-08-27 23:51 ` Kirill Yukhin
2019-08-21 22:45 ` Alexander Turenko
2019-08-19 20:18 ` Konstantin Osipov
2019-08-20 15:26 ` Maxim Melentiev
2019-08-20 16:22 ` Konstantin Osipov
2019-08-27 23:54 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27beb551-6221-6e7e-5bba-61802782fe41@corp.mail.ru \
--to=dmarc-noreply@freelists.org \
--cc=alexander.turenko@tarantool.org \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] Enable support for NOTIFY_SOCKET on macOS' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox