[Tarantool-patches] [PATCH v2] test: flaky replication/gh-5195-qsync-*

[Tarantool-patches] [PATCH v2] test: flaky replication/gh-5195-qsync-*

[Alexander V. Tikhonov]

On heavy loaded hosts found the following issue:

   box.cfg{replication_synchro_quorum = 2}
    | ---
  + | - error: '[string "test_run:wait_cond(function()                ..."]:1: attempt to
  + |     index field ''vclock'' (a nil value)'
    | ...

The issue output was not correct due to wrong output list. Real command
that caused the initial issue was the previous command:

  test_run:wait_cond(function()                                                   \
          local info = box.info.replication[replica_id]                           \
          local lsn = info.downstream.vclock[replica_id]                          \
          return lsn and lsn >= replica_lsn                                       \
  end)

It happened because replication vclock field was not exist at the moment
of its check. To fix the issue, vclock field had to be waited to be
available using test_run:wait_cond() routine.

Closes #5230
---

Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-5230-fix-qsync-write-5195
Issue: https://github.com/tarantool/tarantool/issues/5230

 test/replication/gh-5195-qsync-replica-write.result   | 11 +++++++----
 test/replication/gh-5195-qsync-replica-write.test.lua |  8 ++++----
 2 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/test/replication/gh-5195-qsync-replica-write.result b/test/replication/gh-5195-qsync-replica-write.result
index 3999e8f5e..906f4910d 100644
--- a/test/replication/gh-5195-qsync-replica-write.result
+++ b/test/replication/gh-5195-qsync-replica-write.result
@@ -96,10 +96,13 @@ test_run:wait_downstream(replica_id, {status='follow'})
  | - true
  | ...
 test_run:wait_cond(function()                                                   \
-        local info = box.info.replication[replica_id]                           \
-        local lsn = info.downstream.vclock[replica_id]                          \
-        return lsn and lsn >= replica_lsn                                       \
-end)                                                                            \
+        local vclock = box.info.replication[replica_id].downstream.vclock       \
+        return (vclock and vclock[replica_id] and                               \
+                vclock[replica_id] >= replica_lsn)                              \
+    end) or box.info
+ | ---
+ | - true
+ | ...
 
 box.cfg{replication_synchro_quorum = 2}
  | ---
diff --git a/test/replication/gh-5195-qsync-replica-write.test.lua b/test/replication/gh-5195-qsync-replica-write.test.lua
index 2b9909e21..d7d09fa35 100644
--- a/test/replication/gh-5195-qsync-replica-write.test.lua
+++ b/test/replication/gh-5195-qsync-replica-write.test.lua
@@ -41,10 +41,10 @@ replica_id = test_run:get_server_id('replica')
 replica_lsn = test_run:get_lsn('replica', replica_id)
 test_run:wait_downstream(replica_id, {status='follow'})
 test_run:wait_cond(function()                                                   \
-        local info = box.info.replication[replica_id]                           \
-        local lsn = info.downstream.vclock[replica_id]                          \
-        return lsn and lsn >= replica_lsn                                       \
-end)                                                                            \
+        local vclock = box.info.replication[replica_id].downstream.vclock       \
+        return (vclock and vclock[replica_id] and                               \
+                vclock[replica_id] >= replica_lsn)                              \
+    end) or box.info
 
 box.cfg{replication_synchro_quorum = 2}
 test_run:wait_cond(function() return f:status() == 'dead' end)
-- 
2.17.1

Re: [Tarantool-patches] [PATCH v2] test: flaky replication/gh-5195-qsync-*

[Vladislav Shpilevoy]

Thanks for the patch!

LGTM.