Tarantool development patches archive
 help / color / mirror / Atom feed
From: lvasiliev <lvasiliev@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: Yaroslav Dynnikov <Yaroslav.dynnikov@tarantool.org>,
	tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2] rocks: forward options to luarocks
Date: Mon, 13 Apr 2020 15:03:13 +0300	[thread overview]
Message-ID: <268886cf-8398-9040-0393-57cf7e458b96@tarantool.org> (raw)
In-Reply-To: <5ab92df1-5c37-c213-609b-44ce7bffe26d@tarantool.org>

Update comment and  commit after updating LuaRocks patchset.

diff --git a/third_party/luarocks b/third_party/luarocks
index 1b51b2f..8e8db7f 160000
--- a/third_party/luarocks
+++ b/third_party/luarocks
@@ -1 +1 @@
-Subproject commit 1b51b2fe1c194719a7a8a74220a954a91c21f2a7
+Subproject commit 8e8db7f255a855c585245c288414ceb097576e07


commit 47992ecebf83572b7b69000625ba7e2ccc92f7a6
Author: Leonid <lvasiliev@tarantool.org>
Date:   Fri Nov 15 15:36:33 2019 +0300

     rocks: forward options to luarocks

     The policy for check of luarocks flags has been changed
     (moved from tarantoolctl to luarocks).
     Chdir has been moved to luarocks.

     Closes #4629

     @TarantoolBot document
     Title: Update tarantoolctl rocks
     tarantoolctl rocks commands has been added:
     build
     config
     download
     init
     lint
     new_version
     purge
     which
     write_rockspec

     https://github.com/luarocks/luarocks/wiki/luarocks


On 12.04.2020 20:12, lvasiliev wrote:
> Ok
> 
> commit 39fc7b43d6aad0f0c732ff8938515b8301adab40
> Author: Leonid <lvasiliev@tarantool.org>
> Date:   Fri Nov 15 15:36:33 2019 +0300
> 
>      rocks: forward options to luarocks
> 
>      The policy for check of luarocks flags has been changed
>      (moved from tarantoolctl to luarocks).
>      Chdir has been moved to luarocks.
>      Unsupported flags have been deleted from luarocks
> 
>      Closes #4629
> 
>      @TarantoolBot document
>      Title: Update tarantoolctl rocks
>      tarantoolctl rocks commands has been added:
>      build
>      config
>      download
>      init
>      lint
>      new_version
>      purge
>      which
>      write_rockspec
> 
>      https://github.com/luarocks/luarocks/wiki/luarocks
> 
> 
> On 11.04.2020 17:11, Vladislav Shpilevoy wrote:
>>>      rocks: forward options to luarocks
>>>
>>>      The policy for check of luarocks flags has been changed
>>>      (moved from tarantoolctl to luarocks).
>>>      Chdir has been moved to luarocks.
>>>      Unsupported flags have been deleted from luarocks
>>>
>>>      @TarantoolBot document
>>>      Title: Update tarantoolctl rocks
>>>      tarantoolctl rocks commands has been added:
>>>      build
>>>      config
>>>      download
>>>      init
>>>      lint
>>>      new_version
>>>      purge
>>>      which
>>>      write_rockspec
>>>
>>>      https://github.com/luarocks/luarocks/wiki/luarocks
>>>
>>>      Closes #4629
>>
>> Please, move 'Closes' out of the docbot request. Otherwise it
>> will end up in the doc ticket description. Sorry I didn't notice
>> it earlier.
>>

  reply	other threads:[~2020-04-13 12:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-05 14:49 Leonid Vasiliev
2020-04-09  6:55 ` lvasiliev
2020-04-10  0:00 ` Vladislav Shpilevoy
2020-04-10  9:10   ` lvasiliev
2020-04-11 14:11     ` Vladislav Shpilevoy
2020-04-12 17:12       ` lvasiliev
2020-04-13 12:03         ` lvasiliev [this message]
2020-04-12 20:15 ` Vladislav Shpilevoy
  -- strict thread matches above, loose matches on Subject: below --
2019-11-19  8:56 Leonid

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=268886cf-8398-9040-0393-57cf7e458b96@tarantool.org \
    --to=lvasiliev@tarantool.org \
    --cc=Yaroslav.dynnikov@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v2] rocks: forward options to luarocks' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox