From: "n.pettik" <korablev@tarantool.org> To: tarantool-patches@freelists.org Cc: Roman Khabibov <roman.habibov@tarantool.org> Subject: [tarantool-patches] Re: [PATCH 0/2] sql: store statistics in statN as an array of integers Date: Tue, 12 Feb 2019 02:53:41 +0300 [thread overview] Message-ID: <263D687D-781B-4479-8F96-30B5FD89EB68@tarantool.org> (raw) In-Reply-To: <cover.1548547565.git.roman.habibov@tarantool.org> Travis status is entirely negative - it can’t be compiled. Please, make sure that at least build is successfully finished before sending patch. > On 27 Jan 2019, at 03:28, Roman Khabibov <roman.habibov@tarantool.org> wrote: > > It was necessary to add function for msg pack result in sqlite3 VDBE API. Actually, it wasn’t. You still can use result_blob and set subtype after its invocation. Now it doesn’t matter much. > The patchset is very raw. > There are problems with the old tests that need > to be solved. Ok, could you at least explain or enumerate existing problems (in our char, in ticket comments, wherever you want) and possible solutions. > I do not know if a piece of code with keyword checking works. > Could you send in the reply letter test samples for "unordered" and "noskipscan" > keywords? What kind of samples do you need? To check that it works you need get plan of query (explain query plan …), manually update statisctics in _sql_stat space, probably restart instance to load to in-memory structs new statistics and make sure that plan of query has changed. Ofc not all plans will change, but only those which are related to skip-scan optimisation (don’t remember what the second token is responsible for).
prev parent reply other threads:[~2019-02-11 23:53 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-27 0:28 [tarantool-patches] " Roman Khabibov 2019-01-27 0:28 ` [tarantool-patches] [PATCH 1/2] sql: add sqlite3 msgpack result function Roman Khabibov 2019-02-11 23:53 ` [tarantool-patches] " n.pettik 2019-01-27 0:28 ` [tarantool-patches] [PATCH 2/2] sql: store statistics in statN as an array of integers Roman Khabibov 2019-02-11 23:53 ` [tarantool-patches] " n.pettik 2019-03-01 10:33 ` [tarantool-patches] Re: [PATCH] " Roman Khabibov 2019-03-05 17:54 ` n.pettik 2019-03-12 1:10 ` Roman Khabibov 2019-03-22 15:16 ` n.pettik 2019-02-11 23:53 ` n.pettik [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=263D687D-781B-4479-8F96-30B5FD89EB68@tarantool.org \ --to=korablev@tarantool.org \ --cc=roman.habibov@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='[tarantool-patches] Re: [PATCH 0/2] sql: store statistics in statN as an array of integers' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox