Re: [Tarantool-patches] [PATCH luajit] Fix predict_next() in parser.

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi,


On 8/22/23 18:17, Sergey Kaplun wrote:

<snipped>


>>> +
>>> +local res, err = pcall(res_f)
>>> +
>>> +test:ok(not res, 'loaded function not executed')
>> it is not clear for me what for do you need checking result code. I
>> would omit it.
>>
>> Feel free to ignore.
> Added the following comment to avoid confusing (see the whole iterative
> patch below):
>
> ===================================================================
> diff --git a/test/tarantool-tests/lj-1033-fix-parsing-predict-next.test.lua b/test/tarantool-tests/lj-1033-fix-parsing-predict-next.test.lua
> index 63998d8c..fed3ff6c 100644
> --- a/test/tarantool-tests/lj-1033-fix-parsing-predict-next.test.lua
> +++ b/test/tarantool-tests/lj-1033-fix-parsing-predict-next.test.lua
> @@ -3,10 +3,6 @@ local test = tap.test('lj-1033-fix-parsing-predict-next')
>   
>   test:plan(3)
>   
> -local res_f = loadstring([[
> --- This local variable is necessary, because it emits `KPRI`
> --- bytecode, with which the next `KPRI` bytecode will be merged.
> ---
>   -- The resulting bytecode is the following:
>   --
>   -- 0001    KNIL     0   1
> @@ -16,14 +12,18 @@ local res_f = loadstring([[
>   --
>   -- This MOV doesn't use any variable value from the stack, so the
>   -- attempt to get the name in `predict_next() leads to the crash.
> +local res_f = loadstring([[
> +-- This local variable is necessary, because it emits `KPRI`
> +-- bytecode, with which the next `KPRI` bytecode will be merged.
>   local _
>   for _ in (nil):foo() do end
>   ]])
>   
> -test:ok(res_f, 'chunk loaded sucsessfully')
> +test:ok(res_f, 'chunk loaded successfully')
>   
>   local res, err = pcall(res_f)
>   
> +-- Check consistency with PUC Rio Lua 5.1 behaviour.
>   test:ok(not res, 'loaded function not executed')
>   test:like(err, 'attempt to index a nil value', 'correct error message')
>   
> ===================================================================
>
> Branch is force-pushed.
>
Thanks! LGTM now.


>>
>>> +test:like(err, 'attempt to index a nil value', 'correct error message')
>>> +
>>> +test:done(true)