Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Imeev Mergen <imeevma@tarantool.org>, tarantool-patches@freelists.org
Cc: korablev@tarantool.org
Subject: [tarantool-patches] Re: [PATCH v5 5/6] sql: get results of PRAGMA statement in YAML format
Date: Mon, 4 Feb 2019 16:08:18 +0300	[thread overview]
Message-ID: <2591c7d9-4d3e-308c-39e5-3da864ef000e@tarantool.org> (raw)
In-Reply-To: <9c3b19c5-a1ba-5816-d525-9f6dacc04144@tarantool.org>

Thanks for the fixes!

> commit 3c930d8c81aed9ff25f2d582e8bd7743ff57d861
> Author: Mergen Imeev <imeevma@gmail.com>
> Date:   Thu Dec 13 21:07:31 2018 +0300
> 
>      sql: get results of PRAGMA statement as result set
> 
>      Currently box.sql.execute ('PRAGMA') returns nothing, but prints
>      list of pragmas and their statuses to stdout. Such strategy is
>      considered to be wrong since output of this command would be
>      unavailable for users who redirect stdout, use net box connection
>      etc. This patch makes the command to return result as the rest of
>      SQL commands. The result contains only FLAG-type pragmas and their
>      statuses.
> 
> diff --git a/test/sql/sql-debug.test.lua b/test/sql/sql-debug.test.lua
> index 721ef19..e429c38 100644
> --- a/test/sql/sql-debug.test.lua
> +++ b/test/sql/sql-debug.test.lua
> @@ -10,3 +10,8 @@ result = box.sql.execute('PRAGMA parser_trace')
>   box.sql.execute('PRAGMA parser_trace = 1')
>   box.sql.execute('PRAGMA parser_trace')
>   box.sql.execute('PRAGMA parser_trace = '.. result[1][1])
> +
> +--
> +-- Make PRAGMA command return the result as a result set.
> +--
> +box.sql.execute('PRAGMA')
> 

Why is this test in sql-debug.test.lua instead of pragma.test.lua?

  reply	other threads:[~2019-02-04 13:08 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-29 14:29 [tarantool-patches] [PATCH v5 0/6] sql: set column types for EXPLAIN and PRAGMA imeevma
2019-01-29 14:29 ` [tarantool-patches] [PATCH v5 1/6] sql: remove unused macros from pragma.c and pragma.h imeevma
2019-01-30 13:57   ` [tarantool-patches] " Vladislav Shpilevoy
2019-01-31 14:56     ` Imeev Mergen
2019-01-29 14:29 ` [tarantool-patches] [PATCH v5 2/6] sql: fix "PRAGMA parser_trace" result imeevma
2019-01-30 13:57   ` [tarantool-patches] " Vladislav Shpilevoy
2019-01-31 14:56     ` Imeev Mergen
2019-02-04 13:06       ` Vladislav Shpilevoy
2019-02-09 10:08         ` Mergen Imeev
2019-01-29 14:29 ` [tarantool-patches] [PATCH v5 3/6] sql: Show currently set sql_default_engine imeevma
2019-01-30 13:57   ` [tarantool-patches] " Vladislav Shpilevoy
2019-01-31 14:56     ` Imeev Mergen
2019-01-29 14:29 ` [tarantool-patches] [PATCH v5 4/6] sql: fix "PRAGMA case_sensitive_like" result imeevma
2019-01-30 13:56   ` [tarantool-patches] " Vladislav Shpilevoy
2019-01-31 14:56     ` Imeev Mergen
2019-01-29 14:29 ` [tarantool-patches] [PATCH v5 5/6] sql: get results of PRAGMA statement in YAML format imeevma
2019-01-30 13:56   ` [tarantool-patches] " Vladislav Shpilevoy
2019-01-31 14:56     ` Imeev Mergen
2019-02-04 13:08       ` Vladislav Shpilevoy [this message]
2019-02-09 10:11         ` Mergen Imeev
2019-01-29 14:29 ` [tarantool-patches] [PATCH v5 6/6] sql: set column types for EXPLAIN and PRAGMA imeevma
2019-01-30 13:59 ` [tarantool-patches] Re: [PATCH v5 0/6] " Vladislav Shpilevoy
2019-01-31 14:56   ` Imeev Mergen
2019-02-15 20:44 ` Vladislav Shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2591c7d9-4d3e-308c-39e5-3da864ef000e@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=imeevma@tarantool.org \
    --cc=korablev@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v5 5/6] sql: get results of PRAGMA statement in YAML format' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox