Re: [Tarantool-patches] [PATCH luajit 1/2] Prevent recording of loops with -0 step or NaN values.

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 896 bytes --]

Hi, Sergey,

thanks for the fixes!

Sergey

On 3/13/26 13:07, Sergey Kaplun wrote:


<snipped>

>>> +local function test_trace_recorded(test_payload)
>>> +  jit.flush()
>>> +  -- Reset hotcounters.
>> nit: comment can be omitted
> I prefer not to. There may be the question: why we don't declare this
> parameters once? The reason is that the hotcounters may cause collisions
> and lead to the false-positive tests failures. Should I make the comment
> more verbose?

We reset hotcounters in tests about 470 times (grep -R -B 1 "hotloop=1" 
test | wc -l) and only

15 times we add a comment like "Reset hotcounters.". You add a comment 
here but missed it in the patch

"MIPS64: Avoid unaligned load in lj_vm_exit_interp.". Why we should 
leave comment here and

omit it the aforementioned patch? I'll not insist removing it, just 
interesting, it is not an issue for blocking merge.

>
<snipped>

[-- Attachment #2: Type: text/html, Size: 1877 bytes --]