Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: tarantool-patches@dev.tarantool.org,
	Sergey Kaplun <skaplun@tarantool.org>,
	e.temirgaleev@tarantool.org
Subject: [Tarantool-patches] [PATCH luajit] cmake: drop include(CMakeParseArguments)
Date: Thu,  8 Oct 2026 12:15:36 +0000	[thread overview]
Message-ID: <25636432d3f5dc48c20ecff73cc74aa7e537d5a2.1791461730.git.estetus@gmail.com> (raw)

`cmake_parse_arguments()` is a builtin since CMake 3.5 and the
module is a no-op since then, see [1]. Tarantool is on CMake 3.5
since April 2025.

1. https://cmake.org/cmake/help/latest/module/CMakeParseArguments.html

Part of tarantool/tarantool#13333
---

Branch: https://github.com/tarantool/luajit/tree/ligurio/gh-xxxx-drop-CMakeParseArguments
Related issue: https://github.com/tarantool/tarantool/issues/13333
Related commit: https://github.com/tarantool/tarantool/commit/691aa8717edb84a1f507d822d00a60037419cfe1

 cmake/MakeLuaPath.cmake    | 2 --
 cmake/MakeSourceList.cmake | 2 --
 test/CMakeLists.txt        | 2 --
 3 files changed, 6 deletions(-)

diff --git a/cmake/MakeLuaPath.cmake b/cmake/MakeLuaPath.cmake
index 122b6d534..89c0dea52 100644
--- a/cmake/MakeLuaPath.cmake
+++ b/cmake/MakeLuaPath.cmake
@@ -19,8 +19,6 @@ function(make_lua_path path)
   set(singleValues)
   set(multiValues PATHS)
 
-  # FIXME: if we update to CMake >= 3.5, can remove this line.
-  include(CMakeParseArguments)
   cmake_parse_arguments(${prefix}
                         "${noValues}"
                         "${singleValues}"
diff --git a/cmake/MakeSourceList.cmake b/cmake/MakeSourceList.cmake
index 0be90d602..825906cc4 100644
--- a/cmake/MakeSourceList.cmake
+++ b/cmake/MakeSourceList.cmake
@@ -27,8 +27,6 @@ function(make_source_list list)
   set(singleValues)
   set(multiValues SOURCES)
 
-  # FIXME: if we update to CMake >= 3.5, can remove this line.
-  include(CMakeParseArguments)
   cmake_parse_arguments(${prefix}
                         "${noValues}"
                         "${singleValues}"
diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
index efdfa3d58..e297e80e4 100644
--- a/test/CMakeLists.txt
+++ b/test/CMakeLists.txt
@@ -136,8 +136,6 @@ function(add_test_suite_target target)
   set(singleValues LABELS)
   set(multiValues DEPENDS)
 
-  # FIXME: if we update to CMake >= 3.5, can remove this line.
-  include(CMakeParseArguments)
   cmake_parse_arguments(${prefix}
                         "${noValues}"
                         "${singleValues}"
-- 
2.51.0


                 reply	other threads:[~2026-10-08 12:19 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25636432d3f5dc48c20ecff73cc74aa7e537d5a2.1791461730.git.estetus@gmail.com \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=e.temirgaleev@tarantool.org \
    --cc=estetus@gmail.com \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit] cmake: drop include(CMakeParseArguments)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox