From: Oleg Babin <olegrok@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
tarantool-patches@dev.tarantool.org,
yaroslav.dynnikov@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 vshard 1/2] storage: introduce upgrade strategy
Date: Thu, 26 Mar 2020 18:46:55 +0300 [thread overview]
Message-ID: <2517d6e1-0751-51ba-f5ed-ea064742d4e8@tarantool.org> (raw)
In-Reply-To: <761ca71e8b796a6fef356dffc4b4d31f575abb3c.1585093031.git.v.shpilevoy@tarantool.org>
Hi! Thanks for changes. It was really unexpected for me that such
modifications as were in previous version is prohibited.
LGTM. Except the fact that you store upgrade code in storage/init. IMO
it should be encapsulated in a separate file.
On 25/03/2020 02:44, Vladislav Shpilevoy wrote:
> Since vshard creation it never needed any schema changes. Version
> of vshard schema was always '1', stored in _schema as
> 'oncevshard:storage:1', because it was created by
> box.once('vshard:storage:1').
next prev parent reply other threads:[~2020-03-26 15:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 23:44 [Tarantool-patches] [PATCH v2 vshard 0/2] " Vladislav Shpilevoy
2020-03-24 23:44 ` [Tarantool-patches] [PATCH v2 vshard 1/2] " Vladislav Shpilevoy
2020-03-26 15:46 ` Oleg Babin [this message]
2020-03-24 23:44 ` [Tarantool-patches] [PATCH v2 vshard 2/2] storage: introduce vshard.storage._call() Vladislav Shpilevoy
2020-03-28 18:04 ` [Tarantool-patches] [PATCH v2 vshard 0/2] storage: introduce upgrade strategy Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2517d6e1-0751-51ba-f5ed-ea064742d4e8@tarantool.org \
--to=olegrok@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--cc=yaroslav.dynnikov@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 vshard 1/2] storage: introduce upgrade strategy' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox