From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@dev.tarantool.org, kostja.osipov@gmail.com
Subject: Re: [Tarantool-patches] [PATCH 1/1] replication: use empty password by default
Date: Tue, 5 Nov 2019 15:51:32 +0300 [thread overview]
Message-ID: <24ce061c-0fb2-fd25-01b3-a1bf98db1f7b@tarantool.org> (raw)
In-Reply-To: <c83b11bf88f7249fbce6902e768047dcbcc55401.1572880138.git.v.shpilevoy@tarantool.org>
Also I forgot a description for the test.
Here it is: (force pushed to the branch)
========================================================================
diff --git a/test/replication/gh-4605-empty-password.result b/test/replication/gh-4605-empty-password.result
index 4cb2c37c1..defdfcfcd 100644
--- a/test/replication/gh-4605-empty-password.result
+++ b/test/replication/gh-4605-empty-password.result
@@ -2,6 +2,16 @@
test_run = require('test_run').new()
| ---
| ...
+
+--
+-- gh-4605: replication and netbox both use URI as a remote
+-- resource identifier. If URI does not contain a password, netbox
+-- assumes it is an empty string - ''. But replication's applier
+-- wasn't assuming the same, and just didn't send a password at
+-- all, when it was not specified in the URI. It led to a strange
+-- error message and inconsistent behaviour. The test checks, that
+-- replication now also uses an empty string password by default.
+
box.schema.user.create('test_user', {password = ''})
| ---
| ...
diff --git a/test/replication/gh-4605-empty-password.test.lua b/test/replication/gh-4605-empty-password.test.lua
index 5472b66cd..f42a55f81 100644
--- a/test/replication/gh-4605-empty-password.test.lua
+++ b/test/replication/gh-4605-empty-password.test.lua
@@ -1,4 +1,14 @@
test_run = require('test_run').new()
+
+--
+-- gh-4605: replication and netbox both use URI as a remote
+-- resource identifier. If URI does not contain a password, netbox
+-- assumes it is an empty string - ''. But replication's applier
+-- wasn't assuming the same, and just didn't send a password at
+-- all, when it was not specified in the URI. It led to a strange
+-- error message and inconsistent behaviour. The test checks, that
+-- replication now also uses an empty string password by default.
+
box.schema.user.create('test_user', {password = ''})
box.schema.user.grant('test_user', 'replication')
========================================================================
next prev parent reply other threads:[~2019-11-05 12:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 15:10 Vladislav Shpilevoy
2019-11-04 15:40 ` Konstantin Osipov
2019-11-05 9:45 ` Vladislav Shpilevoy
2019-11-05 12:42 ` Vladislav Shpilevoy
2019-11-05 12:51 ` Vladislav Shpilevoy [this message]
2019-11-05 18:13 ` Konstantin Osipov
2019-11-21 18:40 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24ce061c-0fb2-fd25-01b3-a1bf98db1f7b@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kostja.osipov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/1] replication: use empty password by default' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox