Tarantool development patches archive
 help / color / mirror / Atom feed
From: Georgy Kirichenko <georgy@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Ilya Kosarev <i.kosarev@tarantool.org>, i.kosarev@corp.mail.ru
Subject: [tarantool-patches] Re: [PATCH] recovery: build secondary index in hot standby mode
Date: Tue, 10 Sep 2019 17:40:54 +0300	[thread overview]
Message-ID: <2483390.arBQlrxCkh@localhost> (raw)
In-Reply-To: <20190814183144.17907-1-i.kosarev@tarantool.org>

[-- Attachment #1: Type: text/plain, Size: 598 bytes --]

On Wednesday, August 14, 2019 9:31:44 PM MSK Ilya Kosarev wrote:
Hi, thanks for you patch!
Please see my comments below
>...
>  #include "gc.h"
> +#include "wal.h"
This breaks encapsulation and logic - a wal isn't the object the engine 
interacts with.
> 
>  /* sync snapshot every 16MB */
>...
> 
> -	if (!memtx->force_recovery) {
> +	if (!memtx->force_recovery && wal_dir_lock >= 0) {
The same mistake, it isn't a memtx deal - is there any wal dir and was it 
locked or not.
>...  		/*

I pushed different solution onto your branch, please investigate it.
Also there should be some tests I think.

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      parent reply	other threads:[~2019-09-10 14:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-14 18:31 [tarantool-patches] " Ilya Kosarev
2019-08-14 22:12 ` [tarantool-patches] " Konstantin Osipov
2019-09-10 14:40 ` Georgy Kirichenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2483390.arBQlrxCkh@localhost \
    --to=georgy@tarantool.org \
    --cc=i.kosarev@corp.mail.ru \
    --cc=i.kosarev@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH] recovery: build secondary index in hot standby mode' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox