[tarantool-patches] Re: [PATCH v1 1/1] sql: added tests for TEMP and TEMPORARY clauses

[roman.habibov1@yandex.ru]

>>>  Please, read guidelines carefully.
>>>
>>>>  sql: Tests for CREATE TEMP TABLE and CREATE TEMPORARY TABLE
>>>
>>>  According to our docs:
>>>  — 2. Try to limit the subject line to 50 characters or so.
>>>  — 3. Start the subject line with a capital letter unless it prefixed with a subsystem name and semicolon…
>>  Sorry. I fixed that.
>
> No, you didn’t. Read it again. I see old violations on your branch.
But now?

>> There is exeptions, when these clauses are used.
>
> Typo: ’there are’. Use some spell-checker or whatever.
> Rephrase whole sentence: it seems to be misleading.
Rephrased.

>>>  I would also add tests (or just rewrite yours) which check that complete CREATE TABLE statement doesn’t support TEMP clause:
>>>
>>>  CREATE TEMP TABLE t1(…);
>>>
>>>  CREATE TEMPORARY TABLE t1(…);
>>  + CREATE TEMP TABLE t1();
>>  + CREATE TEMPORARY TABLE t1();
>
> Cmon, use complete form of CREATE TABLE statement.
> You can’t create table with no columns.
diff --git a/test/sql-tap/table.test.lua b/test/sql-tap/table.test.lua
index 84eb884..f0a1cbc 100755
--- a/test/sql-tap/table.test.lua
+++ b/test/sql-tap/table.test.lua
@@ -617,7 +617,7 @@ test:do_execsql2_test(
 test:do_catchsql_test(
 	"temp",
 	[[
-		CREATE TEMP TABLE t1();
+		CREATE TEMP TABLE t1(col1 int, col2 int);
 	]], {
 	-- <temp>
 	1, "near \"TEMP\": syntax error"
@@ -627,7 +627,7 @@ test:do_catchsql_test(
 test:do_catchsql_test(
 	"temporary",
 	[[
-		CREATE TEMPORARY TABLE t1();
+		CREATE TEMPORARY TABLE t1(col1 int, col2 int);
 	]], {
 	-- <temporary>
 	1, "near \"TEMPORARY\": syntax error"