Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org,
	Konstantin Osipov <kostja@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 5/5] swim: introduce dissemination component
Date: Tue, 9 Apr 2019 14:47:20 +0300	[thread overview]
Message-ID: <23c3bcbe-73f2-608b-9bf0-cb9a96c66223@tarantool.org> (raw)
In-Reply-To: <20190409095815.GB16539@chai>



On 09/04/2019 12:58, Konstantin Osipov wrote:
> * Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/04/09 00:29]:
>> Kostja pushed some comment updates. I copy-pasted
>> them below and fixed or reverted some of them with
>> an explanation why.
>>
>> Please, do not forget to answer on this email and others
>> in the thread with an LGTM or new review fixes/comments.
> 
> I can only see one patch, not a stack of 5 patches. 

There is a problem with your email client. The whole patchset
has reached the online storage:
https://www.freelists.org/post/tarantool-patches/PATCH-05-swim-dissemination-component

Additionally, what is strange, you've answered on one of the
previous patches, but now you say, that you do not see them.
🤔🤔🤔🤔🤔🤔🤔🤔🤔🤔🤔🤔🤔🤔🤔🤔🤔🤔🤔🤔🤔🤔🤔🤔🤔🤔

> 
> This one patch is OK to push with the accumulated fixes for the
> comments. 

Unfortunately, it is blocked by the previous patches
in the stack.

> 
> Please re-submit the remaining of the patch stack for review after
> that.

As you wish.

> 
>>
> 
> -- 
> Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
> http://tarantool.io - www.twitter.com/kostja_osipov
> 

  reply	other threads:[~2019-04-09 11:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-05 11:57 [tarantool-patches] [PATCH 0/5] swim " Vladislav Shpilevoy
2019-04-05 11:57 ` [tarantool-patches] [PATCH 1/5] swim: encapsulate member bin info into a 'passport' Vladislav Shpilevoy
2019-04-05 11:57 ` [tarantool-patches] [PATCH 2/5] swim: make members array decoder be a separate function Vladislav Shpilevoy
2019-04-05 11:57 ` [tarantool-patches] [PATCH 3/5] test: speed up swim big cluster failure detection Vladislav Shpilevoy
2019-04-09  8:43   ` [tarantool-patches] " Konstantin Osipov
2019-04-09 11:47     ` Vladislav Shpilevoy
2019-04-05 11:57 ` [tarantool-patches] [PATCH 4/5] test: set packet drop rate instead of flag in swim tests Vladislav Shpilevoy
2019-04-05 11:57 ` [tarantool-patches] [PATCH 5/5] swim: introduce dissemination component Vladislav Shpilevoy
2019-04-08 20:13   ` [tarantool-patches] " Vladislav Shpilevoy
2019-04-09  9:58     ` Konstantin Osipov
2019-04-09 11:47       ` Vladislav Shpilevoy [this message]
2019-04-09 12:25 ` [tarantool-patches] Re: [PATCH 0/5] swim " Vladislav Shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23c3bcbe-73f2-608b-9bf0-cb9a96c66223@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH 5/5] swim: introduce dissemination component' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox