Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Nikita Pettik <korablev@tarantool.org>,
	tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 0/6] sql: extend response metadata
Date: Thu, 28 Nov 2019 23:55:36 +0100	[thread overview]
Message-ID: <23b58aee-f8f7-77d8-347a-8ba0215028dc@tarantool.org> (raw)
In-Reply-To: <cover.1574846892.git.korablev@tarantool.org>

Please, add a docbot request to the final commit. It
should include binary protocol change description.

On 27/11/2019 13:15, Nikita Pettik wrote:
> Branch: https://github.com/tarantool/tarantool/tree/np/gh-4407-extend-sql-metadata
> Issue: https://github.com/tarantool/tarantool/issues/4407
> 
> This patch-set extends metadata with collation, nullability,
> autoincrement and alias properties of resulting set columns.
> Quite straightforward implementation.
> 
> Nikita Pettik (6):
>   sql: refactor resulting set metadata
>   sql: fix possible null dereference in sql_expr_coll()
>   sql: extend result set with collation
>   sql: extend result set with nullability
>   sql: extend result set with autoincrement
>   sql: extend result set with alias
> 
>  src/box/execute.c                                |  65 +++-
>  src/box/iproto_constants.h                       |   4 +
>  src/box/lua/execute.c                            |  22 +-
>  src/box/lua/net_box.c                            |  33 +-
>  src/box/sql/delete.c                             |   6 +-
>  src/box/sql/expr.c                               |   3 +-
>  src/box/sql/insert.c                             |   5 +-
>  src/box/sql/legacy.c                             |   2 +-
>  src/box/sql/pragma.c                             |  14 +-
>  src/box/sql/prepare.c                            |   9 +-
>  src/box/sql/select.c                             |  95 +++--
>  src/box/sql/sqlInt.h                             |  12 +
>  src/box/sql/update.c                             |   6 +-
>  src/box/sql/vdbe.h                               |  41 ++-
>  src/box/sql/vdbeInt.h                            |  17 +-
>  src/box/sql/vdbeapi.c                            | 103 +++---
>  src/box/sql/vdbeaux.c                            | 126 +++++--
>  test/box/sql-update-with-nested-select.result    |   5 +-
>  test/sql-tap/badutf1.test.lua                    |  46 +--
>  test/sql-tap/colname.test.lua                    |  16 +-
>  test/sql-tap/lua/sqltester.lua                   |  29 ++
>  test/sql-tap/select1.test.lua                    |  18 +-
>  test/sql-tap/select4.test.lua                    |   4 +-
>  test/sql-tap/view.test.lua                       |   2 +-
>  test/sql/bind.result                             |  15 +-
>  test/sql/boolean.result                          | 431 ++++++++++++++---------
>  test/sql/check-clear-ephemeral.result            |   5 +-
>  test/sql/collation.result                        | 241 ++++++++-----
>  test/sql/gh-3199-no-mem-leaks.result             | 120 ++++---
>  test/sql/gh2141-delete-trigger-drop-table.result |  20 +-
>  test/sql/gh2251-multiple-update.result           |  10 +-
>  test/sql/iproto.result                           | 110 +++---
>  test/sql/misc.result                             |  25 +-
>  test/sql/on-conflict.result                      |  20 +-
>  test/sql/persistency.result                      | 190 ++++++----
>  test/sql/row-count.result                        |  25 +-
>  test/sql/sql-debug.result                        |  15 +-
>  test/sql/transition.result                       | 190 ++++++----
>  test/sql/types.result                            | 105 +++---
>  test/sql/update-with-nested-select.result        |   5 +-
>  40 files changed, 1376 insertions(+), 834 deletions(-)
> 

      parent reply	other threads:[~2019-11-28 22:55 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-27 12:15 Nikita Pettik
2019-11-27 12:15 ` [Tarantool-patches] [PATCH 1/6] sql: refactor resulting set metadata Nikita Pettik
2019-11-28 22:41   ` Vladislav Shpilevoy
2019-12-05 11:39     ` Nikita Pettik
2019-12-05 23:58       ` Vladislav Shpilevoy
2019-12-06 12:48         ` Nikita Pettik
2019-12-17 13:23   ` Sergey Ostanevich
2019-11-27 12:15 ` [Tarantool-patches] [PATCH 2/6] sql: fix possible null dereference in sql_expr_coll() Nikita Pettik
2019-11-28 22:42   ` Vladislav Shpilevoy
2019-12-05 11:40     ` Nikita Pettik
2019-12-05 23:59       ` Vladislav Shpilevoy
2019-12-06 12:48         ` Nikita Pettik
2019-12-17 13:30           ` Sergey Ostanevich
2019-12-17 14:44             ` Nikita Pettik
2019-12-17 19:53               ` Nikita Pettik
2019-11-27 12:15 ` [Tarantool-patches] [PATCH 3/6] sql: extend result set with collation Nikita Pettik
2019-11-28 22:41   ` Vladislav Shpilevoy
2019-12-05 11:50     ` Nikita Pettik
2019-12-18 11:08   ` Sergey Ostanevich
2019-12-24  0:44     ` Nikita Pettik
2019-11-27 12:15 ` [Tarantool-patches] [PATCH 4/6] sql: extend result set with nullability Nikita Pettik
2019-11-28 22:41   ` Vladislav Shpilevoy
2019-12-05 11:50     ` Nikita Pettik
2019-12-06  0:00       ` Vladislav Shpilevoy
2019-12-06 12:49         ` Nikita Pettik
2019-12-18 13:31   ` Sergey Ostanevich
2019-11-27 12:15 ` [Tarantool-patches] [PATCH 5/6] sql: extend result set with autoincrement Nikita Pettik
2019-11-28 22:41   ` Vladislav Shpilevoy
2019-12-05 11:51     ` Nikita Pettik
2019-12-18 15:17   ` Sergey Ostanevich
2019-12-24  0:47     ` Nikita Pettik
2019-11-27 12:15 ` [Tarantool-patches] [PATCH 6/6] sql: extend result set with alias Nikita Pettik
2019-11-28 22:41   ` Vladislav Shpilevoy
2019-12-05 11:51     ` Nikita Pettik
2019-12-06  0:02       ` Vladislav Shpilevoy
2019-12-06 12:50         ` Nikita Pettik
2019-12-06 21:52           ` Vladislav Shpilevoy
2019-12-19 15:17   ` Sergey Ostanevich
2019-12-24  0:27     ` Nikita Pettik
2019-11-28 22:55 ` Vladislav Shpilevoy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23b58aee-f8f7-77d8-347a-8ba0215028dc@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=korablev@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 0/6] sql: extend response metadata' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox