Tarantool development patches archive
 help / color / mirror / Atom feed
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
To: Oleg Piskunov <o.piskunov@tarantool.org>,
	Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
	Alexander Turenko <alexander.turenko@tarantool.org>
Subject: [Tarantool-patches] [PATCH v2 2/7] build: fix static build w/ dockerfile with cmake
Date: Tue, 26 May 2020 17:42:33 +0300	[thread overview]
Message-ID: <23557817ca293a7b00eebf0ac02422ec486409e6.1590503508.git.avtikhon@tarantool.org> (raw)
In-Reply-To: <cover.1590503508.git.avtikhon@tarantool.org>
In-Reply-To: <cover.1590503508.git.avtikhon@tarantool.org>

Building the image got the issue:

  [  1%] Performing configure step for 'bundled-libcurl-project'
  CMake Warning at CMakeLists.txt:50 (message):
    the curl cmake build system is poorly maintained.  Be aware

  -- curl version=[7.66.0-DEV]
  -- Found c-ares: /tarantool/build/ares/dest/lib/libcares.a
  Found *nroff option: -- -man
  CMake Error at /usr/share/cmake/Modules/FindOpenSSL.cmake:278 (list):
    list GET given empty list
  Call Stack (most recent call first):
    CMakeLists.txt:347 (find_package)

Root cause of the issue that Dockerfile uses globaly
installed openSSL with:

  cmake ... -DOPENSSL_ROOT_DIR=/usr/local ...

Its cmake build file:

  /usr/share/cmake/Modules/FindOpenSSL.cmake

fails on parsing the SSL version:

it has:
       REGEX "^#define[\t ]+OPENSSL_VERSION_NUMBER[\t ]+0x([0-9a-fA-F])+.*")

but it should to use:
       REGEX "^#[\t ]*define[\t ]+OPENSSL_VERSION_NUMBER[\t ]+0x([0-9a-fA-F])+.*")

Closes #5019
---
 Dockerfile.staticbuild | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Dockerfile.staticbuild b/Dockerfile.staticbuild
index f67f46f5e..01419dcc5 100644
--- a/Dockerfile.staticbuild
+++ b/Dockerfile.staticbuild
@@ -79,6 +79,7 @@ RUN set -x && \
 
 RUN pip install -r /tarantool/test-run/requirements.txt
 
+# cp FindOpenSSL.cmake /usr/share/cmake/Modules/FindOpenSSL.cmake && \
 RUN set -x && \
     cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo \
          -DENABLE_DIST:BOOL=ON \
@@ -86,6 +87,8 @@ RUN set -x && \
          -DOPENSSL_USE_STATIC_LIBS=ON \
          -DOPENSSL_ROOT_DIR=/usr/local \
          . && \
+    sed 's%#define%#[\\t ]*define%g' -i \
+        /usr/share/cmake/Modules/FindOpenSSL.cmake && \
     make -j && make install
 
 ARG RUN_TESTS
-- 
2.17.1

  parent reply	other threads:[~2020-05-26 14:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-26 14:42 [Tarantool-patches] [PATCH v2 0/7] Implement OOS build Alexander V. Tikhonov
2020-05-26 14:42 ` [Tarantool-patches] [PATCH v2 1/7] build: static build needs more cleanup in sources Alexander V. Tikhonov
2020-06-26 13:51   ` Alexander Turenko
2020-07-03 11:13   ` Kirill Yukhin
2020-05-26 14:42 ` Alexander V. Tikhonov [this message]
2020-05-26 14:42 ` [Tarantool-patches] [PATCH v2 3/7] build: enable cmake in curl build Alexander V. Tikhonov
2020-05-26 14:42 ` [Tarantool-patches] [PATCH v2 4/7] Fix curl repository for out-of-source build Alexander V. Tikhonov
2020-05-26 14:42 ` [Tarantool-patches] [PATCH v2 5/7] build: change autoconf to cmake in curl build Alexander V. Tikhonov
2020-05-26 14:42 ` [Tarantool-patches] [PATCH v2 6/7] Skip failing test from out-of-source build Alexander V. Tikhonov
2020-05-26 14:42 ` [Tarantool-patches] [PATCH v2 7/7] gitlab-ci: add " Alexander V. Tikhonov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23557817ca293a7b00eebf0ac02422ec486409e6.1590503508.git.avtikhon@tarantool.org \
    --to=avtikhon@tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=o.piskunov@tarantool.org \
    --cc=sergeyb@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v2 2/7] build: fix static build w/ dockerfile with cmake' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox