[tarantool-patches] Re: [PATCH v1 1/1] sql: Tests for CREATE TEMP TABLE and CREATE TEMPORARY TABLE

["n.pettik" <korablev@tarantool.org>]

Please, read guidelines carefully.

>sql: Tests for CREATE TEMP TABLE and CREATE TEMPORARY TABLE

According to our docs:
— 2. Try to limit the subject line to 50 characters or so.
— 3. Start the subject line with a capital letter unless it prefixed with a subsystem name and semicolon…

Also, it is not clear what have you done with these ’tests’: removed/fixed/added etc.

>+
>+-- gh-2166 Tables with TEMP and TEMPORARY were removed before.
>+       

Leading space at the last line. Enable showing whitespaces to avoid such codestyle violations.

>+       })
>+test:do_catchsql_test(
>+       "temporary",

>+       1, "near \"TEMPORARY\": syntax error"
>+       -- <temporary>
>+       })
>test:do_execsql2_test(

Separate tests with blank line.

I would also add tests (or just rewrite yours) which check that complete CREATE TABLE statement doesn’t support TEMP clause:

CREATE TEMP TABLE t1(…);

CREATE TEMPORARY TABLE t1(…);