From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>,
tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] txn: convert flags to explicit bitfield
Date: Wed, 17 Feb 2021 22:15:30 +0100 [thread overview]
Message-ID: <21a79be2-2af3-9eab-588f-c110aecfd0b6@tarantool.org> (raw)
In-Reply-To: <20210215140149.194727-1-gorcunov@gmail.com>
Hi! Thanks for the patch!
> @@ -535,7 +535,7 @@ txn_complete_fail(struct txn *txn)
> txn_rollback_one_stmt(txn, stmt);
> if (txn->engine != NULL)
> engine_rollback(txn->engine, txn);
> - if (txn_has_flag(txn, TXN_HAS_TRIGGERS))
> + if (txn->flags & TXN_HAS_TRIGGERS)
1. Did you do a self-review before sending this? Can you
tell yourself what is wrong here?
2. What was wrong with the idea of having the helpers
but operating on bitfields? And having has_flags() instead
of has_flag() to check presense of all specified flags +
clear_flags() to remove all specified flags.
I don't understand. I think we discussed it already 2 or 3
times and all seemed to agree?
next prev parent reply other threads:[~2021-02-17 21:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 14:01 Cyrill Gorcunov via Tarantool-patches
2021-02-17 21:15 ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-02-17 21:45 ` Cyrill Gorcunov via Tarantool-patches
2021-02-18 8:32 ` Cyrill Gorcunov via Tarantool-patches
2021-02-23 21:37 ` Vladislav Shpilevoy via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21a79be2-2af3-9eab-588f-c110aecfd0b6@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] txn: convert flags to explicit bitfield' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox