From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 8ADE56EC58; Thu, 18 Feb 2021 00:15:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8ADE56EC58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1613596537; bh=IlwGScjQX5ndAQVTf9hWwCh5bx6X1NoncKnWlQ5Knb8=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=lAceNencrPtj3sBLA0HjjkaeNGXM/65mOeF5mVVx5pVGhlq+Qg1Fsp0byTQ9IU368 4gn3XpdrXqg+O1p7oJLXTtvz8tVPsfveZHwGYdieNeZIBExn7KSDLNZglXKM5R0KSt bJNDIWZbC+IIes+c610iBD73XObJvAiVi8U85ruA= Received: from smtp36.i.mail.ru (smtp36.i.mail.ru [94.100.177.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 513406EC58 for ; Thu, 18 Feb 2021 00:15:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 513406EC58 Received: by smtp36.i.mail.ru with esmtpa (envelope-from ) id 1lCUAV-00059D-5V; Thu, 18 Feb 2021 00:15:31 +0300 To: Cyrill Gorcunov , tml References: <20210215140149.194727-1-gorcunov@gmail.com> Message-ID: <21a79be2-2af3-9eab-588f-c110aecfd0b6@tarantool.org> Date: Wed, 17 Feb 2021 22:15:30 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210215140149.194727-1-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD975C3EC174F5669228C980786C9DBA186ED94931C77F7596E182A05F538085040213957E11E2F2670C9B474E910CF9E37BA5BB95DFED942D7BB94E2FAB7CAEFAE X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7466896EF24E80F12EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006379C6642364E0E74208638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC018EC8C0DA057E001AB5ABB7067CBAB3BC64ED74CEACBDDA389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C02F11D39E7306DD338941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6CDE59DDCCE53AF2BCC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C2249D245858782CAF09476E601842F6C81A12EF20D2F80756B5F7E9C4E3C761E06A776E601842F6C81A127C277FBC8AE2E8B0425D6A0565C26973AA81AA40904B5D9DBF02ECDB25306B2B25CBF701D1BE8734AD6D5ED66289B5278DA827A17800CE732FCE54C4D9A645493EC92FD9297F6715571747095F342E857739F23D657EF2BD5E8D9A59859A8B603913CCF128142C9089D37D7C0E48F6C5571747095F342E857739F23D657EF2B6825BDBE14D8E70227F01F88B6EF2528BD9CCCA9EDD067B1EDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5D426A30DBEF02236723A2635EA8D6B7A5D4CCC3F9FC24ADED59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D348D68DCC07DD06FF5CED44952DDC9588C30BFC0B5D3B0EA6EAE6FC5C9772C0A7B82101303EB8CAF0A1D7E09C32AA3244CD4D4275C8671C2A54C6516E5E1C34215F2F5F14F68F1805B927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojJkVkVdRHm/8fG2d44zWElg== X-Mailru-Sender: 504CC1E875BF3E7D9BC0E5172ADA3110970873AF18C54BCFCD05132C3B735A90D126F917A4825BD607784C02288277CA03E0582D3806FB6A5317862B1921BA260ED6CFD6382C13A6112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] txn: convert flags to explicit bitfield X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the patch! > @@ -535,7 +535,7 @@ txn_complete_fail(struct txn *txn) > txn_rollback_one_stmt(txn, stmt); > if (txn->engine != NULL) > engine_rollback(txn->engine, txn); > - if (txn_has_flag(txn, TXN_HAS_TRIGGERS)) > + if (txn->flags & TXN_HAS_TRIGGERS) 1. Did you do a self-review before sending this? Can you tell yourself what is wrong here? 2. What was wrong with the idea of having the helpers but operating on bitfields? And having has_flags() instead of has_flag() to check presense of all specified flags + clear_flags() to remove all specified flags. I don't understand. I think we discussed it already 2 or 3 times and all seemed to agree?