From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Chris Sosnin <k.sosnin@tarantool.org>,
korablev@tarantool.org, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 2/2] sql: fix assertion fault in SELECT * FROM "_vfunc"
Date: Sun, 22 Mar 2020 20:42:16 +0100 [thread overview]
Message-ID: <2193f919-8553-1511-18ea-0f249985d820@tarantool.org> (raw)
In-Reply-To: <b24f405988edd5a52ebe2a2675234287669e2124.1584608715.git.k.sosnin@tarantool.org>
> diff --git a/src/box/lua/upgrade.lua b/src/box/lua/upgrade.lua
> index 92c3b460e..2fea6f943 100644
> --- a/src/box/lua/upgrade.lua
> +++ b/src/box/lua/upgrade.lua
> @@ -974,6 +974,12 @@ local function upgrade_to_2_3_1()
> create_session_settings_space()
> end
>
> +local function upgrade_to_2_3_1_1()
> + local _func = box.space[box.schema.FUNC_ID]
> + local _vfunc = box.space[box.schema.VFUNC_ID]
> + _vfunc:format(_func:format())
It is worth adding a comment why such a trivial thing should be done.
next prev parent reply other threads:[~2020-03-22 19:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 9:14 [Tarantool-patches] [PATCH 0/2] " Chris Sosnin
2020-03-19 9:14 ` [Tarantool-patches] [PATCH 1/2] box: allow schema upgrades within a release Chris Sosnin
2020-03-22 19:43 ` Vladislav Shpilevoy
2020-03-25 19:10 ` Chris Sosnin
2020-03-19 9:14 ` [Tarantool-patches] [PATCH 2/2] sql: fix assertion fault in SELECT * FROM "_vfunc" Chris Sosnin
2020-03-22 19:42 ` Vladislav Shpilevoy [this message]
2020-03-25 19:18 ` Chris Sosnin
2020-03-27 23:37 ` [Tarantool-patches] [PATCH 0/2] " Vladislav Shpilevoy
2020-04-24 10:14 Chris Sosnin
2020-04-24 10:14 ` [Tarantool-patches] [PATCH 2/2] sql: " Chris Sosnin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2193f919-8553-1511-18ea-0f249985d820@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=k.sosnin@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2/2] sql: fix assertion fault in SELECT * FROM "_vfunc"' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox