Re: [Tarantool-patches] [PATCH 1/3] luacheck: fix warnings in test/box

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

On 13.01.2021 19:38, Vladislav Shpilevoy wrote:
> Hi! Thanks for the fixes!
>
> Consider my fixes on top of this commit on the branch, and below with
> explanations.
Thanks for your fixes! I have squashed your commit.

<snipped>

> @@ -50,11 +50,11 @@ local function test_insert_delete(n)
>   end
>   
>   return {
> -    clear = clear;
> -    create_space = create_space;
> -    delete = delete;
> -    drop_space = drop_space;
> -    dump = dump;
> -    fill = fill;
> -    test_insert_delete = test_insert_delete;
> +    clear = clear,
> +    create_space = create_space,
> +    delete = delete,
> +    drop_space = drop_space,
> +    dump = dump,
> +    fill = fill,
> +    test_insert_delete = test_insert_delete,
> ====================
>
> We don't use ';' anywhere. It may still be used in some old code,
> but not in the new code. I have no idea though if it is stated
> anywhere formally.

actually there is a rule in Lua guideline [1]: "do not use semicolon as 
table separator (only comma)"

<snipped>

1. 
https://www.tarantool.io/en/doc/latest/dev_guide/lua_style_guide/#idioms-and-patterns